Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2406973002: Only run camera tests on devices with cameras (Closed)

Created:
4 years, 2 months ago by kraush
Modified:
4 years, 2 months ago
Reviewers:
whywhat, Torne
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only run camera tests on devices with cameras Changes tests that verify camera functionality to only run on devices that have a camera BUG=654515 Committed: https://crrev.com/fc878d9d24b71733165134bfd123995a120289e4 Cr-Commit-Position: refs/heads/master@{#424440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/SysUtils.java View 2 chunks +13 lines, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java View 1 chunk +3 lines, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/RestrictionSkipCheck.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kraush
Hi avayvod, Hi Torne, Can you take a look at this suppression for devices with ...
4 years, 2 months ago (2016-10-10 19:19:16 UTC) #2
whywhat
media/ lgtm
4 years, 2 months ago (2016-10-10 20:07:41 UTC) #3
Torne
base lgtm
4 years, 2 months ago (2016-10-11 12:52:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406973002/1
4 years, 2 months ago (2016-10-11 14:36:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 15:55:58 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 15:58:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc878d9d24b71733165134bfd123995a120289e4
Cr-Commit-Position: refs/heads/master@{#424440}

Powered by Google App Engine
This is Rietveld 408576698