Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2406933002: Fix crash in ShowBookmarkBubble. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in ShowBookmarkBubble. BookmarkBubbleView::ShowBubble can return null. BUG=653802 Committed: https://crrev.com/be64cef5970cb99d10548fea08eacede41387de5 Cr-Commit-Position: refs/heads/master@{#424192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Evan Stade
4 years, 2 months ago (2016-10-10 17:31:28 UTC) #3
msw
lgtm
4 years, 2 months ago (2016-10-10 18:08:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406933002/1
4 years, 2 months ago (2016-10-10 18:23:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 18:30:36 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 18:33:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be64cef5970cb99d10548fea08eacede41387de5
Cr-Commit-Position: refs/heads/master@{#424192}

Powered by Google App Engine
This is Rietveld 408576698