Move payment_request.mojom file to components/

Move payment_request.mojom file to components/

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=

Committed: https://crrev.com/f26b33b194cd7939cdbdf885150803583370db17
Cr-Commit-Position: refs/heads/master@{#427077}

[Kevin Bailey, 2016-10-10 17:10:23]

Description was changed from

==========
Move payment_request.mojom file to components/

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=
==========

to

==========
Move payment_request.mojom file to components/

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=
==========

[Kevin Bailey, 2016-10-10 17:10:24]

krb@chromium.org changed reviewers:
+ rouslan@chromium.org

[Kevin Bailey, 2016-10-10 17:17:25]

Hi Rouslan,

Here are the changes specific to moving the .mojom file.

[please use gerrit instead, 2016-10-12 23:36:40]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 23:37:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:40:16]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[please use gerrit instead, 2016-10-12 23:51:50]

Thank you for the patch! :-)

You appear to need a rebase.

[please use gerrit instead, 2016-10-12 23:51:55]

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (left):

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:99:
mojo::WTFArray<PaymentItemPtr>::From(input.additionalDisplayItems());
Is it not possible to continue using WTFArray::From()?

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:101:
input.additionalDisplayItems()[i]));
It's shorter to call "PaymentItem::From()" instead of
"TypeConverter<PaymentItemPtr, blink::PaymentItem>::Convert()". See line 93 for
an example. They are equivalent in functionality, though.

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:181: bool
validatePaymentDetails(const mojo::PaymentDetailsPtr&);
Pretty sure that this declaration is no-op, because the only definition is
inside of the anonymous namespace on line 305. Please remove.

[Kevin Bailey, 2016-10-13 18:30:42]

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (left):

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:99:
mojo::WTFArray<PaymentItemPtr>::From(input.additionalDisplayItems());
On 2016/10/12 23:51:55, rouslan (slow 10.10-10.17) wrote:
> Is it not possible to continue using WTFArray::From()?

The destination field has changed from mojo::WTFArray to WTF::Vector.

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:101:
input.additionalDisplayItems()[i]));
On 2016/10/12 23:51:55, rouslan (slow 10.10-10.17) wrote:
> It's shorter to call "PaymentItem::From()" instead of
> "TypeConverter<PaymentItemPtr, blink::PaymentItem>::Convert()". See line 93
for
> an example. They are equivalent in functionality, though.

Ok, changed all 4 occurrences.

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:181: bool
validatePaymentDetails(const mojo::PaymentDetailsPtr&);
On 2016/10/12 23:51:55, rouslan (slow 10.10-10.17) wrote:
> Pretty sure that this declaration is no-op, because the only definition is
> inside of the anonymous namespace on line 305. Please remove.

Was left-over. Gone.

[please use gerrit instead, 2016-10-13 20:24:00]

LGTM % comment. Regardless of your findings, this patch looks good to go. Thank
you!

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (left):

https://codereview.chromium.org/2406923002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:99:
mojo::WTFArray<PaymentItemPtr>::From(input.additionalDisplayItems());
On 2016/10/13 18:30:42, Kevin Bailey wrote:
> On 2016/10/12 23:51:55, rouslan (slow 10.10-10.17) wrote:
> > Is it not possible to continue using WTFArray::From()?
> 
> The destination field has changed from mojo::WTFArray to WTF::Vector.

Please see if there's a shorter way to write this, like a copy constructor.

[Kevin Bailey, 2016-10-14 18:58:15]

Looks like a function call got removed. Anyways, let me know if you'd like any
tweaks to the new function. It sounds like the CL needs external review before
submission.

[please use gerrit instead, 2016-10-17 17:07:27]

still lgtm

[Kevin Bailey, 2016-10-19 13:32:15]

krb@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[Kevin Bailey, 2016-10-19 13:34:21]

Hi owners,

mkwst@, can you take a look at:

components/payments/payment_request.mojom
third_party/WebKit/public/BUILD.gn
third_party/WebKit/public/platform/modules/payments/OWNERS
third_party/WebKit/public/platform/modules/payments/payment_request.mojom

jochen@, can you take a look at:

chrome/android/BUILD.gn

thanks!

[jochen (gone - plz use gerrit), 2016-10-19 14:01:22]

chrome/android lgtm

[Mike West, 2016-10-20 09:33:51]

Moving mojom LGTM.

[Kevin Bailey, 2016-10-20 13:26:29]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 13:26:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 13:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 13:28:34]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Kevin Bailey, 2016-10-20 14:58:40]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 14:59:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 15:24:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 15:24:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Kevin Bailey, 2016-10-20 17:00:19]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 17:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-20 17:37:43]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-10-20 17:37:44]

drive-by comments while looking at dependency issue (will respond on other
thread too)

https://codereview.chromium.org/2406923002/diff/160001/components/payments/BU...
File components/payments/BUILD.gn (right):

https://codereview.chromium.org/2406923002/diff/160001/components/payments/BU...
components/payments/BUILD.gn:8: sources = [
Typically this rule and the mojom would live in
components/payments/public/interfaces, because components/payments will likely
be private implementation code.

https://codereview.chromium.org/2406923002/diff/160001/components/payments/pa...
File components/payments/payment_request.mojom (right):

https://codereview.chromium.org/2406923002/diff/160001/components/payments/pa...
components/payments/payment_request.mojom:6: module blink.mojom;
Hopefully this is changing to payments.mojom?

[commit-bot: I haz the power, 2016-10-20 17:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 17:51:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kevin Bailey, 2016-10-20 18:29:09]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 18:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:33:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Kevin Bailey, 2016-10-20 18:50:09]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 18:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:28:58]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Kevin Bailey, 2016-10-20 21:11:01]

The CQ bit was checked by krb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 21:11:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 22:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:43:48]

Dry run: This issue passed the CQ dry run.

[Kevin Bailey, 2016-10-24 13:53:12]

The CQ bit was checked by krb@chromium.org

[Kevin Bailey, 2016-10-24 13:53:12]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
rouslan@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2406923002/#ps220001
(title: "Add Android test dependencies")

[commit-bot: I haz the power, 2016-10-24 13:53:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 15:52:10]

Description was changed from

==========
Move payment_request.mojom file to components/

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=
==========

to

==========
Move payment_request.mojom file to components/

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=
==========

[commit-bot: I haz the power, 2016-10-24 15:52:12]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-10-24 16:19:17]

Description was changed from

==========
Move payment_request.mojom file to components/

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=
==========

to

==========
Move payment_request.mojom file to components/

Currently, only Blink depends on payment_requet.mojom. Going
forward, all the platforms will, so moving it to a more generic
location.

BUG=

Committed: https://crrev.com/f26b33b194cd7939cdbdf885150803583370db17
Cr-Commit-Position: refs/heads/master@{#427077}
==========

[commit-bot: I haz the power, 2016-10-24 16:19:18]

Patchset 12 (id:??) landed as
https://crrev.com/f26b33b194cd7939cdbdf885150803583370db17
Cr-Commit-Position: refs/heads/master@{#427077}