Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 24069003: Remove dead code from Dictionary (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use
Visibility:
Public.

Description

Remove dead code from Dictionary Remove getEventListener() method from the Dictionary class as it does not appear to be used and it always returns 0. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/bindings/v8/Dictionary.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-10 13:32:54 UTC) #1
haraken
LGTM
7 years, 3 months ago (2013-09-10 13:54:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/24069003/1
7 years, 3 months ago (2013-09-10 13:55:46 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 15:56:15 UTC) #4
Message was sent while issue was closed.
Change committed as 157523

Powered by Google App Engine
This is Rietveld 408576698