Issue 2406863003: Move class DeclarationResolver to its own file.

Issue 2406863003: Move class DeclarationResolver to its own file. (Closed)

Created:
4 years, 2 months ago by Paul Berry

Modified:
4 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Move class DeclarationResolver to its own file. Auxiliary classes ElementGatherer, ElementMismatchException, and ExistingElementResolver, which were only used by DeclarationResolver, are also moved. (No functional change; just code motion). R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/cf5f9e0a38df24468c4ea794e26ffd1455b676d9

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+731 lines, -732 lines)			Patch
D	pkg/analyzer/lib/src/dart/element/utilities.dart	View	1 chunk	+0 lines, -34 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/declaration_resolver.dart	View	1 chunk	+729 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	4 chunks	+0 lines, -697 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/declaration_resolver_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Assuming there were no other changes (because I didn't look at the moved code), lgtm.

4 years, 2 months ago (2016-10-10 18:26:53 UTC) #3

Paul Berry

4 years, 2 months ago (2016-10-10 18:43:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cf5f9e0a38df24468c4ea794e26ffd1455b676d9 (presubmit successful).