webpages_playback: use gsutil instead of API, no shell_utils

webpages_playback: use gsutil instead of API, no shell_utils

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406863002

Committed: https://skia.googlesource.com/skia/+/644638c03705c0f81ec368cfb8e326efbbed31bb

[borenet2, 2016-10-10 12:28:34]

Description was changed from

==========
webpages_playback: use gsutil instead of API, no shell_utils

BUG=skia:5843
==========

to

==========
webpages_playback: use gsutil instead of API, no shell_utils

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406863002
==========

[borenet, 2016-10-10 12:31:03]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com

[borenet, 2016-10-10 12:31:03]

I haven't tested this. AFAICT there's no trybot for the RecreateSKPs canary?

[rmistry, 2016-10-10 12:36:25]

lgtm

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback.py
File tools/skp/webpages_playback.py (right):

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:459: def does_storage_object_exist(self, path):
Nit: path -> name (the subclasses both call it name).

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:506: def does_storage_object_exist(self, name,
*args):
Remove *args since overridden method no longer has it.

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:510: def download_file(self, name, local_path,
*args):
Remove *args since overridden method no longer has it.

[rmistry, 2016-10-10 12:36:47]

On 2016/10/10 12:31:03, borenet wrote:
> I haven't tested this. AFAICT there's no trybot for the RecreateSKPs canary?

I guess not :(
Maybe trigger the canary after this lands?

[borenet, 2016-10-10 12:40:14]

Yeah, I'll trigger the canary after this lands.

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback.py
File tools/skp/webpages_playback.py (right):

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:459: def does_storage_object_exist(self, path):
On 2016/10/10 12:36:25, rmistry wrote:
> Nit: path -> name (the subclasses both call it name).

Done.

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:506: def does_storage_object_exist(self, name,
*args):
On 2016/10/10 12:36:25, rmistry wrote:
> Remove *args since overridden method no longer has it.

Done.

https://codereview.chromium.org/2406863002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:510: def download_file(self, name, local_path,
*args):
On 2016/10/10 12:36:25, rmistry wrote:
> Remove *args since overridden method no longer has it.

Done.

[borenet, 2016-10-10 12:40:20]

The CQ bit was checked by borenet@google.com

[borenet, 2016-10-10 12:40:20]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2406863002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-10-10 12:40:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 12:57:19]

Description was changed from

==========
webpages_playback: use gsutil instead of API, no shell_utils

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406863002
==========

to

==========
webpages_playback: use gsutil instead of API, no shell_utils

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2406863002

Committed:
https://skia.googlesource.com/skia/+/644638c03705c0f81ec368cfb8e326efbbed31bb
==========

[commit-bot: I haz the power, 2016-10-10 12:57:20]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/644638c03705c0f81ec368cfb8e326efbbed31bb