Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2406803003: Get rid of ParseInfo::lazy (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of ParseInfo::lazy BUG=v8:5501 Committed: https://crrev.com/86ec09231827c498b5627c425032654632fa7fe2 Cr-Commit-Position: refs/heads/master@{#40160}

Patch Set 1 #

Patch Set 2 : Use is_toplevel instead of sfi for background parsing #

Patch Set 3 : restore dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M src/background-parsing-task.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parse-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 1 2 2 chunks +5 lines, -9 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-10 15:07:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-10 15:16:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406803003/40001
4 years, 2 months ago (2016-10-10 18:40:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26059)
4 years, 2 months ago (2016-10-10 18:47:14 UTC) #14
Toon Verwaest
Marja: ptal parser Ahaas: ptal asm test
4 years, 2 months ago (2016-10-10 19:23:58 UTC) #16
marja
lgtm
4 years, 2 months ago (2016-10-11 07:50:23 UTC) #17
ahaas
On 2016/10/11 at 07:50:23, marja wrote: > lgtm wasm lgtm
4 years, 2 months ago (2016-10-11 07:51:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406803003/40001
4 years, 2 months ago (2016-10-11 10:34:14 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 10:36:59 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 10:37:14 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/86ec09231827c498b5627c425032654632fa7fe2
Cr-Commit-Position: refs/heads/master@{#40160}

Powered by Google App Engine
This is Rietveld 408576698