Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 2406803002: [turbofan] Enforce native context specialization. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enforce native context specialization. There were once plans to generate cross-context code with TurboFan, however that doesn't fit into the model anymore, and so all of this is essentially dead untested code (and thus most likely already broken in subtle ways). With this mode still in place it would also be a lot harder to make inlining based on SharedFunctionInfo work. BUG=v8:2206, v8:5499 R=jarin@chromium.org Committed: https://crrev.com/f6bd23f244c6b86ea970b49dc9ee34e41e06338a Cr-Commit-Position: refs/heads/master@{#40109}

Patch Set 1 #

Patch Set 2 : Remove unused variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -515 lines) Patch
M src/compilation-info.h View 2 chunks +8 lines, -17 lines 0 comments Download
M src/compiler/js-call-reducer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 5 chunks +4 lines, -39 lines 0 comments Download
M src/compiler/js-create-lowering.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 19 chunks +28 lines, -85 lines 0 comments Download
M src/compiler/js-global-object-specialization.h View 3 chunks +4 lines, -8 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 7 chunks +9 lines, -34 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 5 chunks +10 lines, -14 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 16 chunks +25 lines, -51 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/node-properties.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/function-tester.cc View 2 chunks +1 line, -5 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D test/mjsunit/regress/regress-568765.js View 1 chunk +0 lines, -93 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/test-utils.h View 3 chunks +12 lines, -2 lines 0 comments Download
M test/unittests/test-utils.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Benedikt Meurer
Hey Jaro, Here's the thing we agreed on. Please take a look. Thanks, Benedikt
4 years, 2 months ago (2016-10-10 05:20:00 UTC) #11
Jarin
lgtm
4 years, 2 months ago (2016-10-10 05:50:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406803002/20001
4 years, 2 months ago (2016-10-10 05:51:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 05:53:37 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 05:54:00 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6bd23f244c6b86ea970b49dc9ee34e41e06338a
Cr-Commit-Position: refs/heads/master@{#40109}

Powered by Google App Engine
This is Rietveld 408576698