Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 2406753005: [MD settings] remove print icons (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove print icons This CL removes the cloud print icon and print icon from the respective rows in md-settings. Minor: the right arrow was also added to the print row. BUG=654546 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4f74d6ada736f09f2957d4ea71aa89e8f906e94c Cr-Commit-Position: refs/heads/master@{#424329}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/settings/icons.html View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/printing_page.html View 2 chunks +6 lines, -6 lines 2 comments Download

Messages

Total messages: 15 (10 generated)
dschuyler
https://codereview.chromium.org/2406753005/diff/1/chrome/browser/resources/settings/printing_page/printing_page.html File chrome/browser/resources/settings/printing_page/printing_page.html (left): https://codereview.chromium.org/2406753005/diff/1/chrome/browser/resources/settings/printing_page/printing_page.html#oldcode28 chrome/browser/resources/settings/printing_page/printing_page.html:28: <iron-icon icon="cr:print"></iron-icon> I didn't remove the cr:print icon from ...
4 years, 2 months ago (2016-10-10 21:04:43 UTC) #6
dpapad
lgtm
4 years, 2 months ago (2016-10-10 21:16:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406753005/1
4 years, 2 months ago (2016-10-11 01:18:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 01:25:01 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 01:27:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f74d6ada736f09f2957d4ea71aa89e8f906e94c
Cr-Commit-Position: refs/heads/master@{#424329}

Powered by Google App Engine
This is Rietveld 408576698