cc: Make pending visible rect active tree tiles be in the NOW bin.

cc: Make pending visible rect active tree tiles be in the NOW bin.

This patch changes the BINs of the active tree tiles that lie in the
pending tree's visible rect be in the NOW bin. This change is to ensure
that these tiles are allowed to use the hard memory limit in the tile
manager, since they may contain tiles that are required for activation.

R=sunnyps@chromium.org
BUG=652884
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7d2136eca32d2ad075122b8210d47d8ab2315070
Cr-Commit-Position: refs/heads/master@{#424244}

[vmpstr, 2016-10-10 16:24:19]

Description was changed from

==========
cc: Make pending visible rect active tree tiles be in the NOW bin.

This patch changes the BINs of the active tree tiles that lie in the
pending tree's visible rect be in the NOW bin. This change is to ensure
that these tiles are allowed to use the hard memory limit in the tile
manager, since they may contain tiles that are required for activation.

R=sunnyps@chromium.org
BUG=652884
==========

to

==========
cc: Make pending visible rect active tree tiles be in the NOW bin.

This patch changes the BINs of the active tree tiles that lie in the
pending tree's visible rect be in the NOW bin. This change is to ensure
that these tiles are allowed to use the hard memory limit in the tile
manager, since they may contain tiles that are required for activation.

R=sunnyps@chromium.org
BUG=652884
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-10-10 20:16:23]

ptal

[sunnyps, 2016-10-10 20:22:31]

lgtm

https://codereview.chromium.org/2406753004/diff/20001/cc/tiles/raster_tile_pr...
File cc/tiles/raster_tile_priority_queue_all.cc (right):

https://codereview.chromium.org/2406753004/diff/20001/cc/tiles/raster_tile_pr...
cc/tiles/raster_tile_priority_queue_all.cc:154: if (active_priority.priority_bin
>= TilePriority::SOON &&
Not blocking this CL but can we have a test for this behavior i.e. active tree
has SOON tiles and pending tree has NOW tiles.

[vmpstr, 2016-10-10 20:24:59]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[vmpstr, 2016-10-10 20:25:05]

The CQ bit was unchecked by vmpstr@chromium.org

[vmpstr, 2016-10-10 20:26:12]

https://codereview.chromium.org/2406753004/diff/20001/cc/tiles/raster_tile_pr...
File cc/tiles/raster_tile_priority_queue_all.cc (right):

https://codereview.chromium.org/2406753004/diff/20001/cc/tiles/raster_tile_pr...
cc/tiles/raster_tile_priority_queue_all.cc:154: if (active_priority.priority_bin
>= TilePriority::SOON &&
On 2016/10/10 20:22:31, sunnyps wrote:
> Not blocking this CL but can we have a test for this behavior i.e. active tree
> has SOON tiles and pending tree has NOW tiles.

I think the test I updated covers this, but I'll add more.

[vmpstr, 2016-10-10 20:26:17]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:26:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:21:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 21:24:04]

Description was changed from

==========
cc: Make pending visible rect active tree tiles be in the NOW bin.

This patch changes the BINs of the active tree tiles that lie in the
pending tree's visible rect be in the NOW bin. This change is to ensure
that these tiles are allowed to use the hard memory limit in the tile
manager, since they may contain tiles that are required for activation.

R=sunnyps@chromium.org
BUG=652884
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Make pending visible rect active tree tiles be in the NOW bin.

This patch changes the BINs of the active tree tiles that lie in the
pending tree's visible rect be in the NOW bin. This change is to ensure
that these tiles are allowed to use the hard memory limit in the tile
manager, since they may contain tiles that are required for activation.

R=sunnyps@chromium.org
BUG=652884
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7d2136eca32d2ad075122b8210d47d8ab2315070
Cr-Commit-Position: refs/heads/master@{#424244}
==========

[commit-bot: I haz the power, 2016-10-10 21:24:05]

Patchset 2 (id:??) landed as
https://crrev.com/7d2136eca32d2ad075122b8210d47d8ab2315070
Cr-Commit-Position: refs/heads/master@{#424244}