|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by tapted Modified:
4 years, 2 months ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode().
The call was added in r72539 to ensure notifications are not shown when
another app has fullscreen (e.g. games or the screensaver).
r178470 added additional calls using Cocoa APIs which made it redundant,
so just delete the call to CGDisplayIsCaptured().
Verified that attempts to show notifications when running an old
fullscreen game or with the screensaver active are correctly suppressed.
Traced to ensure CGDisplayIsCaptured() would have been responsible for
doing the same in these cases.
BUG=650849
Committed: https://crrev.com/5cde3b4543c7d79f23e9b15dd70318cba70e57ff
Cr-Commit-Position: refs/heads/master@{#424272}
Patch Set 1 #Patch Set 2 : Remove unrelated patchset dep #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). The call was added in r72539 to ensure notifications are not shown when another app has fullscreen (e.g. games or the screensaver). r178470 added additional calls using Cocoa APIs which made it redundant, so just delete the call to CGDisplayIsCaptured(). Verified that attempts to show notifications when running an old fullscreen game or with the screensaver active are correctly suppressed and traced to ensure CGDisplayIsCaptured() would do the same. BUG=650849 ========== to ========== Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). The call was added in r72539 to ensure notifications are not shown when another app has fullscreen (e.g. games or the screensaver). r178470 added additional calls using Cocoa APIs which made it redundant, so just delete the call to CGDisplayIsCaptured(). Verified that attempts to show notifications when running an old fullscreen game or with the screensaver active are correctly suppressed. Traced to ensure CGDisplayIsCaptured() would have been responsible for doing the same in these cases. BUG=650849 ==========
tapted@chromium.org changed reviewers: + avi@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi avi, please take a look
lgtm
The CQ bit was checked by tapted@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2406763002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by tapted@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2406753003/#ps20001 (title: "Remove unrelated patchset dep")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). The call was added in r72539 to ensure notifications are not shown when another app has fullscreen (e.g. games or the screensaver). r178470 added additional calls using Cocoa APIs which made it redundant, so just delete the call to CGDisplayIsCaptured(). Verified that attempts to show notifications when running an old fullscreen game or with the screensaver active are correctly suppressed. Traced to ensure CGDisplayIsCaptured() would have been responsible for doing the same in these cases. BUG=650849 ========== to ========== Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). The call was added in r72539 to ensure notifications are not shown when another app has fullscreen (e.g. games or the screensaver). r178470 added additional calls using Cocoa APIs which made it redundant, so just delete the call to CGDisplayIsCaptured(). Verified that attempts to show notifications when running an old fullscreen game or with the screensaver active are correctly suppressed. Traced to ensure CGDisplayIsCaptured() would have been responsible for doing the same in these cases. BUG=650849 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). The call was added in r72539 to ensure notifications are not shown when another app has fullscreen (e.g. games or the screensaver). r178470 added additional calls using Cocoa APIs which made it redundant, so just delete the call to CGDisplayIsCaptured(). Verified that attempts to show notifications when running an old fullscreen game or with the screensaver active are correctly suppressed. Traced to ensure CGDisplayIsCaptured() would have been responsible for doing the same in these cases. BUG=650849 ========== to ========== Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). The call was added in r72539 to ensure notifications are not shown when another app has fullscreen (e.g. games or the screensaver). r178470 added additional calls using Cocoa APIs which made it redundant, so just delete the call to CGDisplayIsCaptured(). Verified that attempts to show notifications when running an old fullscreen game or with the screensaver active are correctly suppressed. Traced to ensure CGDisplayIsCaptured() would have been responsible for doing the same in these cases. BUG=650849 Committed: https://crrev.com/5cde3b4543c7d79f23e9b15dd70318cba70e57ff Cr-Commit-Position: refs/heads/master@{#424272} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5cde3b4543c7d79f23e9b15dd70318cba70e57ff Cr-Commit-Position: refs/heads/master@{#424272} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
