Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2406753003: Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). (Closed)

Created:
4 years, 2 months ago by tapted
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Remove deprecated call to CGDisplayIsCaptured IsFullScreenMode(). The call was added in r72539 to ensure notifications are not shown when another app has fullscreen (e.g. games or the screensaver). r178470 added additional calls using Cocoa APIs which made it redundant, so just delete the call to CGDisplayIsCaptured(). Verified that attempts to show notifications when running an old fullscreen game or with the screensaver active are correctly suppressed. Traced to ensure CGDisplayIsCaptured() would have been responsible for doing the same in these cases. BUG=650849 Committed: https://crrev.com/5cde3b4543c7d79f23e9b15dd70318cba70e57ff Cr-Commit-Position: refs/heads/master@{#424272}

Patch Set 1 #

Patch Set 2 : Remove unrelated patchset dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/fullscreen_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
tapted
Hi avi, please take a look
4 years, 2 months ago (2016-10-10 06:01:14 UTC) #7
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-10 15:13:01 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2406763002 Patch 1). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-10 21:13:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406753003/20001
4 years, 2 months ago (2016-10-10 22:26:53 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 22:56:39 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 22:58:03 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5cde3b4543c7d79f23e9b15dd70318cba70e57ff
Cr-Commit-Position: refs/heads/master@{#424272}

Powered by Google App Engine
This is Rietveld 408576698