Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: content/public/common/zygote_fork_delegate_linux.h

Issue 240673002: Simplify ZygoteForkDelegate API further (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't leak real PID to NaCl child processes Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/zygote/nacl_fork_delegate_linux.cc ('k') | content/zygote/zygote_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/zygote_fork_delegate_linux.h
diff --git a/content/public/common/zygote_fork_delegate_linux.h b/content/public/common/zygote_fork_delegate_linux.h
index 0e926ea009382b692d0fde0340c50e2bf467b0cf..58028ca0e8129f342d0fa00f8d640bb8e24c16cc 100644
--- a/content/public/common/zygote_fork_delegate_linux.h
+++ b/content/public/common/zygote_fork_delegate_linux.h
@@ -59,13 +59,11 @@ class ZygoteForkDelegate {
// suid sandbox, Fork() returns the Linux process ID.
// This method is not aware of any potential pid namespaces, so it'll
// return a raw pid just like fork() would.
+ // Delegate is responsible for communicating the channel ID to the
+ // newly created child process.
virtual pid_t Fork(const std::string& process_type,
- const std::vector<int>& fds) = 0;
-
- // After a successful fork, signal the child to indicate that
- // the child's PID has been received. Also communicate the
- // channel ID as a part of acknowledgement message.
- virtual bool AckChild(int fd, const std::string& channel_id) = 0;
+ const std::vector<int>& fds,
+ const std::string& channel_id) = 0;
// The fork delegate must also assume the role of waiting for its children
// since the caller will not be their parents and cannot do it. |pid| here
« no previous file with comments | « components/nacl/zygote/nacl_fork_delegate_linux.cc ('k') | content/zygote/zygote_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698