components/nacl/zygote/nacl_fork_delegate_linux.h - Issue 240673002: Simplify ZygoteForkDelegate API further

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/zygote/nacl_fork_delegate_linux.h

Issue 240673002: Simplify ZygoteForkDelegate API further (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't leak real PID to NaCl child processes Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/zygote/nacl_fork_delegate_linux.h

diff --git a/components/nacl/zygote/nacl_fork_delegate_linux.h b/components/nacl/zygote/nacl_fork_delegate_linux.h

index afd5e0213f55d22208cef85e88455faa9cac36e8..3239b058a70fc2e26dba31130b19f3dc58dfe482 100644

--- a/components/nacl/zygote/nacl_fork_delegate_linux.h

+++ b/components/nacl/zygote/nacl_fork_delegate_linux.h

@@ -29,8 +29,8 @@ class NaClForkDelegate : public content::ZygoteForkDelegate {

virtual bool CanHelp(const std::string& process_type, std::string* uma_name,

int* uma_sample, int* uma_boundary_value) OVERRIDE;

virtual pid_t Fork(const std::string& process_type,

- const std::vector<int>& fds) OVERRIDE;

- virtual bool AckChild(int fd, const std::string& channel_id) OVERRIDE;

+ const std::vector<int>& fds,

+ const std::string& channel_id) OVERRIDE;

virtual bool GetTerminationStatus(pid_t pid, bool known_dead,

base::TerminationStatus* status,

int* exit_code) OVERRIDE;