Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 2406703002: tracing: remove sampling state profiler (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/Heap.cpp ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index da6d06ab4a741c0ad91d2270321656812f5f762d..ce2ba90164c3810e91c762226146f62924a43ce1 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -108,9 +108,6 @@ class ParkThreadsScope final {
bool parkThreads() {
TRACE_EVENT0("blink_gc", "ThreadHeap::ParkThreadsScope");
- const char* samplingState = TRACE_EVENT_GET_SAMPLING_STATE();
- if (m_state->isMainThread())
- TRACE_EVENT_SET_SAMPLING_STATE("blink_gc", "BlinkGCWaiting");
// TODO(haraken): In an unlikely coincidence that two threads decide
// to collect garbage at the same time, avoid doing two GCs in
@@ -126,8 +123,6 @@ class ParkThreadsScope final {
50));
timeToStopThreadsHistogram.count(timeForStoppingThreads);
- if (m_state->isMainThread())
- TRACE_EVENT_SET_NONCONST_SAMPLING_STATE(samplingState);
return m_shouldResumeThreads;
}
@@ -1682,7 +1677,6 @@ void ThreadState::collectGarbage(BlinkGC::StackState stackState,
TRACE_EVENT2("blink_gc,devtools.timeline", "BlinkGCMarking", "lazySweeping",
gcType == BlinkGC::GCWithoutSweep, "gcReason",
gcReasonString(reason));
- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink_gc", "BlinkGC");
double startTime = WTF::currentTimeMS();
if (gcType == BlinkGC::TakeSnapshot)
« no previous file with comments | « third_party/WebKit/Source/platform/heap/Heap.cpp ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698