Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2406703002: tracing: remove sampling state profiler (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 173bdd2495910fb06f5ebe38eac3a8cd0d72b3e8..1ec2a2a8c0ff351a1f463b355bc006d60f14d80c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -461,7 +461,6 @@ v8::MaybeLocal<v8::Script> V8ScriptRunner::compileScript(
TRACE_EVENT2(
"v8,devtools.timeline", "v8.compile", "fileName", fileName.utf8(), "data",
InspectorCompileScriptEvent::data(fileName, scriptStartPosition));
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Compile");
ASSERT(!streamer || resource);
ASSERT(!resource || resource->cacheHandler() == cacheHandler);
@@ -502,7 +501,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::runCompiledScript(
ASSERT(!script.IsEmpty());
ScopedFrameBlamer frameBlamer(
context->isDocument() ? toDocument(context)->frame() : nullptr);
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
TRACE_EVENT1("v8", "v8.run", "fileName",
TRACE_STR_COPY(*v8::String::Utf8Value(
script->GetUnboundScript()->GetScriptName())));
@@ -546,7 +544,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::compileAndRunInternalScript(
return v8::MaybeLocal<v8::Value>();
TRACE_EVENT0("v8", "v8.run");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::MaybeLocal<v8::Value> result = script->Run(isolate->GetCurrentContext());
@@ -558,7 +555,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::runCompiledInternalScript(
v8::Isolate* isolate,
v8::Local<v8::Script> script) {
TRACE_EVENT0("v8", "v8.run");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::MaybeLocal<v8::Value> result = script->Run(isolate->GetCurrentContext());
@@ -573,7 +569,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callAsConstructor(
int argc,
v8::Local<v8::Value> argv[]) {
TRACE_EVENT0("v8", "v8.callAsConstructor");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
int depth = v8::MicrotasksScope::GetCurrentDepth(isolate);
if (depth >= kMaxRecursionDepth)
@@ -619,7 +614,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callFunction(
ScopedFrameBlamer frameBlamer(
context->isDocument() ? toDocument(context)->frame() : nullptr);
TRACE_EVENT0("v8", "v8.callFunction");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
int depth = v8::MicrotasksScope::GetCurrentDepth(isolate);
if (depth >= kMaxRecursionDepth)
@@ -657,7 +651,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callInternalFunction(
v8::Local<v8::Value> args[],
v8::Isolate* isolate) {
TRACE_EVENT0("v8", "v8.callFunction");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::MaybeLocal<v8::Value> result =
@@ -670,7 +663,6 @@ v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObject(
v8::Isolate* isolate,
v8::Local<v8::ObjectTemplate> objectTemplate) {
TRACE_EVENT0("v8", "v8.newInstance");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
@@ -686,7 +678,6 @@ v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObject(
int argc,
v8::Local<v8::Value> argv[]) {
TRACE_EVENT0("v8", "v8.newInstance");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
@@ -703,7 +694,6 @@ v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObjectInDocument(
int argc,
v8::Local<v8::Value> argv[]) {
TRACE_EVENT0("v8", "v8.newInstance");
- TRACE_EVENT_SCOPED_SAMPLING_STATE("v8", "V8Execution");
if (ScriptForbiddenScope::isScriptForbidden()) {
throwScriptForbiddenException(isolate);
return v8::MaybeLocal<v8::Object>();

Powered by Google App Engine
This is Rietveld 408576698