Build: disable CFI when LTO is disabled

Build: disable CFI when LTO is disabled

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org

Committed: https://crrev.com/b2472ea7c13e04309fc6bf21c5c537071705e859
Cr-Commit-Position: refs/heads/master@{#424816}

[Tom (Use chromium acct), 2016-10-07 23:45:52]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 23:46:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 01:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 01:19:28]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-10-08 16:46:23]

lgtm

[Tom (Use chromium acct), 2016-10-10 20:41:46]

Description was changed from

==========
Build: don't use CFI when not using LTO

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org
==========

to

==========
Build: don't use CFI when not using LTO

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org
==========

[Tom (Use chromium acct), 2016-10-10 20:41:51]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-10-10 20:42:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 22:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:21:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tom (Use chromium acct), 2016-10-12 01:20:40]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-10-12 01:21:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 01:32:01]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Tom (Use chromium acct), 2016-10-12 02:13:43]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 02:14:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 02:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 02:46:41]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-10-12 19:12:18]

Description was changed from

==========
Build: don't use CFI when not using LTO

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org
==========

to

==========
Build: disable CFI when LTO is disabled

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org
==========

[Tom (Use chromium acct), 2016-10-12 19:12:24]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-10-12 19:12:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:21:17]

Description was changed from

==========
Build: disable CFI when LTO is disabled

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org
==========

to

==========
Build: disable CFI when LTO is disabled

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-10-12 19:21:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-12 19:24:02]

Description was changed from

==========
Build: disable CFI when LTO is disabled

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org
==========

to

==========
Build: disable CFI when LTO is disabled

Clang CFI relies on link-time optimization, so disable CFI when
allow_posix_link_time_opt = false.
http://clang.llvm.org/docs/ControlFlowIntegrity.html

This was leading to linker errors on an official build with LTO disabled,
such as:
error: obj/native_client/src/shared/gio/libgio.a: no archive symbol table

R=dpranke@chromium.org

Committed: https://crrev.com/b2472ea7c13e04309fc6bf21c5c537071705e859
Cr-Commit-Position: refs/heads/master@{#424816}
==========

[commit-bot: I haz the power, 2016-10-12 19:24:03]

Patchset 1 (id:??) landed as
https://crrev.com/b2472ea7c13e04309fc6bf21c5c537071705e859
Cr-Commit-Position: refs/heads/master@{#424816}