chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java - Issue 2406573002: 📰 Persist category dismissals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2406573002: 📰 Persist category dismissals (Closed)

Patch Set: rebase and rewrite Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

index cc83745a439d0a56a0fdb6ffabf5665a78c5531b..d8a00305d1f26f2bb52d8342e986f86710028dce 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

@@ -166,8 +166,8 @@ public void resetSections(boolean alwaysAllowEmptySections) {

int i = 0;

for (int category : categories) {

int categoryStatus = suggestionsSource.getCategoryStatus(category);

- assert categoryStatus != CategoryStatus.NOT_PROVIDED;

if (categoryStatus == CategoryStatus.LOADING_ERROR

+ || categoryStatus == CategoryStatus.NOT_PROVIDED

|| categoryStatus == CategoryStatus.CATEGORY_EXPLICITLY_DISABLED)

continue;

« no previous file with comments | « no previous file | chrome/browser/prefs/browser_prefs.cc » ('j') | components/ntp_snippets/category_factory.cc » ('J')