new gc callbacks with isolate parameters

new gc callbacks with isolate parameters

R=svenpanne@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=16770

[Sven Panne, 2013-09-17 11:25:19]

https://codereview.chromium.org/24065005/diff/5001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/24065005/diff/5001/include/v8.h#newcode3870
include/v8.h:3870: typedef void (*GCPrologueCallback)(GCType type,
GCCallbackFlags flags);
Does this even compile with the new definitions below?

https://codereview.chromium.org/24065005/diff/5001/include/v8.h#newcode3873
include/v8.h:3873: typedef void (*GCCallback)();
We can remove this, I think...

https://codereview.chromium.org/24065005/diff/5001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/24065005/diff/5001/src/heap.h#newcode2039
src/heap.h:2039: bool pass_isolate_;
Why do we need this flag? It seems like there is only 1 kind of callback left
after this CL. Or I'm confused...

[dcarney, 2013-09-17 11:30:39]

https://codereview.chromium.org/24065005/diff/5001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/24065005/diff/5001/include/v8.h#newcode3870
include/v8.h:3870: typedef void (*GCPrologueCallback)(GCType type,
GCCallbackFlags flags);
On 2013/09/17 11:25:19, Sven Panne wrote:
> Does this even compile with the new definitions below?

Sure.  They are in the v8::Isolate:: namespace.  I can move them back to v8::
after blink is cutover

https://codereview.chromium.org/24065005/diff/5001/include/v8.h#newcode3873
include/v8.h:3873: typedef void (*GCCallback)();
On 2013/09/17 11:25:19, Sven Panne wrote:
> We can remove this, I think...

on it.

https://codereview.chromium.org/24065005/diff/5001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/24065005/diff/5001/src/heap.h#newcode2039
src/heap.h:2039: bool pass_isolate_;
On 2013/09/17 11:25:19, Sven Panne wrote:
> Why do we need this flag? It seems like there is only 1 kind of callback left
> after this CL. Or I'm confused...

No, there's still two.  I have to cut blink over and then go through and delete
a bunch of stuff

[Sven Panne, 2013-09-17 12:34:27]

LGTM. Namespace confusion on my side... o_O

[dcarney, 2013-09-17 12:37:38]

Committed patchset #2 manually as r16770 (presubmit successful).