Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 24065004: Fix TV build (Closed)

Created:
7 years, 3 months ago by wonsik
Modified:
7 years, 3 months ago
Reviewers:
qinmin
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/media/android/webmediaplayer_proxy_android.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wonsik
PTAL
7 years, 3 months ago (2013-09-16 02:53:02 UTC) #1
qinmin
https://codereview.chromium.org/24065004/diff/1/content/renderer/media/android/webmediaplayer_proxy_android.h File content/renderer/media/android/webmediaplayer_proxy_android.h (right): https://codereview.chromium.org/24065004/diff/1/content/renderer/media/android/webmediaplayer_proxy_android.h#newcode17 content/renderer/media/android/webmediaplayer_proxy_android.h:17: #include "ui/gfx/rect_f.h" nit: use gtv guard
7 years, 3 months ago (2013-09-16 03:27:20 UTC) #2
qinmin
lgtm
7 years, 3 months ago (2013-09-16 03:27:35 UTC) #3
wonsik
https://codereview.chromium.org/24065004/diff/1/content/renderer/media/android/webmediaplayer_proxy_android.h File content/renderer/media/android/webmediaplayer_proxy_android.h (right): https://codereview.chromium.org/24065004/diff/1/content/renderer/media/android/webmediaplayer_proxy_android.h#newcode17 content/renderer/media/android/webmediaplayer_proxy_android.h:17: #include "ui/gfx/rect_f.h" On 2013/09/16 03:27:20, qinmin wrote: > nit: ...
7 years, 3 months ago (2013-09-16 04:15:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wonsik@chromium.org/24065004/7001
7 years, 3 months ago (2013-09-16 04:15:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79208
7 years, 3 months ago (2013-09-16 13:26:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wonsik@chromium.org/24065004/7001
7 years, 3 months ago (2013-09-16 22:48:08 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 00:35:06 UTC) #8
Message was sent while issue was closed.
Change committed as 223487

Powered by Google App Engine
This is Rietveld 408576698