Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: components/history/core/browser/history_backend.h

Issue 2406423003: Remove MessageLoop::current() from history_service.cc (Closed)
Patch Set: CR sdefresne #11 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_backend.h
diff --git a/components/history/core/browser/history_backend.h b/components/history/core/browser/history_backend.h
index 0d044f7b33467c24075eaaa0f6d246407a63d3fe..130d9b7b614085893230f11d58d2106102820da7 100644
--- a/components/history/core/browser/history_backend.h
+++ b/components/history/core/browser/history_backend.h
@@ -41,7 +41,6 @@ class TestingProfile;
struct ThumbnailScore;
namespace base {
-class MessageLoop;
class SingleThreadTaskRunner;
}
@@ -457,8 +456,9 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// Sets the task to run and the message loop to run it on when this object
// is destroyed. See HistoryService::SetOnBackendDestroyTask for a more
// complete description.
- void SetOnBackendDestroyTask(base::MessageLoop* message_loop,
- const base::Closure& task);
+ void SetOnBackendDestroyTask(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ const base::Closure& task);
// Adds the given rows to the database if it doesn't exist. A visit will be
// added for each given URL at the last visit time in the URLRow if the
@@ -852,7 +852,7 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
base::Time first_recorded_time_;
// When set, this is the task that should be invoked on destruction.
- base::MessageLoop* backend_destroy_message_loop_;
+ scoped_refptr<base::SingleThreadTaskRunner> backend_destroy_task_runner_;
base::Closure backend_destroy_task_;
// Tracks page transition types.
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698