Clean up Assignment Create in BlimpClientContextImpl.

blimp/client/core/session/identity_source.h

Index: blimp/client/core/session/identity_source.h
diff --git a/blimp/client/core/session/identity_source.h b/blimp/client/core/session/identity_source.h
index 30663102f5a05dc9fd066e93921a531ee97c4055..ecd70d385ddb41f9836b6095040dc3b27e8e5d9d 100644
--- a/blimp/client/core/session/identity_source.h
+++ b/blimp/client/core/session/identity_source.h
@@ -25,8 +25,10 @@ class IdentitySource : public OAuth2TokenService::Consumer,
  public:
   typedef base::Callback<void(const std::string&)> TokenCallback;

[David Trainor- moved to gerrit, 2016/10/20 16:50:32]

Make this using for consistency :D

[CJ, 2016/10/20 20:52:58]

Done.

 
-  explicit IdentitySource(BlimpClientContextDelegate* delegate,
-                          const TokenCallback& callback);
+  explicit IdentitySource(
+      std::unique_ptr<IdentityProvider> identity_provider,
+      base::Callback<void(const GoogleServiceAuthError&)> error_callback,

[David Trainor- moved to gerrit, 2016/10/20 16:50:32]

put "using TokenErrorCallback = base::Callback<void(const
GoogleServiceAuthError&)>;" above and use TokenErrorCallback as the param type.

[CJ, 2016/10/20 20:52:58]

Done.

+      const TokenCallback& callback);
   ~IdentitySource() override;
 
   // Start Blimp authentication by requesting OAuth2 token from Google.
@@ -63,6 +65,8 @@ class IdentitySource : public OAuth2TokenService::Consumer,
   // OAuth2TokenService::Consumer callback get called.
   std::unique_ptr<OAuth2TokenService::Request> token_request_;
 
+  base::Callback<void(const GoogleServiceAuthError&)> error_callback_;
+
   // Callback after OAuth2 token is fetched.
   TokenCallback token_callback_;
 
@@ -76,8 +80,6 @@ class IdentitySource : public OAuth2TokenService::Consumer,
   // Current retry count due to request cancellation.
   int retry_times_;
 
-  BlimpClientContextDelegate* delegate_;
-
   DISALLOW_COPY_AND_ASSIGN(IdentitySource);
 };