Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: blimp/client/core/context/BUILD.gn

Issue 2406403003: Clean up Assignment Create in BlimpClientContextImpl. (Closed)
Patch Set: Addresses dtrainor's #14 comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/client/core/context/assignment_fetcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 source_set("context") { 10 source_set("context") {
11 visibility = [ 11 visibility = [
12 ":unit_tests", 12 ":unit_tests",
13 "//blimp/client/app:session", # TODO(nyquist): Remove this. See crbug/65196 4. 13 "//blimp/client/app:session", # TODO(nyquist): Remove this. See crbug/65196 4.
14 "//blimp/client/core", 14 "//blimp/client/core",
15 "//blimp/engine:browser_tests", # TODO(nyquist): Remove this. See crbug/653 789. 15 "//blimp/engine:browser_tests", # TODO(nyquist): Remove this. See crbug/653 789.
16 ] 16 ]
17 17
18 sources = [ 18 sources = [
19 "assignment_fetcher.cc",
20 "assignment_fetcher.h",
19 "blimp_client_context_impl.cc", 21 "blimp_client_context_impl.cc",
20 "blimp_client_context_impl.h", 22 "blimp_client_context_impl.h",
21 ] 23 ]
22 24
23 public_deps = [ 25 public_deps = [
24 "//base", 26 "//base",
25 "//blimp/client/core/compositor:compositor", 27 "//blimp/client/core/compositor:compositor",
26 "//blimp/client/core/contents", 28 "//blimp/client/core/contents",
27 "//blimp/client/core/session", 29 "//blimp/client/core/session",
28 "//blimp/client/public:public_headers", 30 "//blimp/client/public:public_headers",
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 generate_jni("dummy_context_jni_headers") { 139 generate_jni("dummy_context_jni_headers") {
138 visibility = [ ":*" ] 140 visibility = [ ":*" ]
139 141
140 sources = [ 142 sources = [
141 "android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java", 143 "android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java",
142 ] 144 ]
143 145
144 jni_package = "blimp/client/core" 146 jni_package = "blimp/client/core"
145 } 147 }
146 } 148 }
OLDNEW
« no previous file with comments | « no previous file | blimp/client/core/context/assignment_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698