DBC: Pull BadTypeError out of AssertAssignable

DBC: Pull BadTypeError out of AssertAssignable

This was allocating a handle which is not allowed in the simulator loop.

Small improvement in Flutter's layout_bench in checked
mode. 15k us -> 14k us. 7% improvement.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/f713658b71c5764bca9c9a90812d54f6586b0a5d

[zra, 2016-10-11 17:42:23]

Description was changed from

==========
DBC: Pull BadTypeError out of AssertAssignable

This was allocating a handle which is not allowed in the simulator loop.
==========

to

==========
DBC: Pull BadTypeError out of AssertAssignable

This was allocating a handle which is not allowed in the simulator loop.

Small improvement in Flutter's layout_bench in checked
mode. 15k us -> 14k us. 7% improvement.
==========

[zra, 2016-10-11 17:42:37]

zra@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-10-11 17:55:18]

Lgtm

https://codereview.chromium.org/2406383002/diff/20001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2406383002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2675: BYTECODE(BadTypeError, 0);
Maybe add the same comment here:
// Stack: instance, type args, type, name

[zra, 2016-10-11 18:04:09]

https://codereview.chromium.org/2406383002/diff/20001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2406383002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:2675: BYTECODE(BadTypeError, 0);
On 2016/10/11 17:55:17, Florian Schneider wrote:
> Maybe add the same comment here:
> // Stack: instance, type args, type, name

Done.

[zra, 2016-10-11 18:04:21]

Description was changed from

==========
DBC: Pull BadTypeError out of AssertAssignable

This was allocating a handle which is not allowed in the simulator loop.

Small improvement in Flutter's layout_bench in checked
mode. 15k us -> 14k us. 7% improvement.
==========

to

==========
DBC: Pull BadTypeError out of AssertAssignable

This was allocating a handle which is not allowed in the simulator loop.

Small improvement in Flutter's layout_bench in checked
mode. 15k us -> 14k us. 7% improvement.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f713658b71c5764bca9c9a90812d54f6586b0a5d
==========

[zra, 2016-10-11 18:04:22]

Committed patchset #3 (id:40001) manually as
f713658b71c5764bca9c9a90812d54f6586b0a5d (presubmit successful).