Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 2406373004: X87: [fullcodegen] Don't count CallIC calls as patching ICs. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [fullcodegen] Don't count CallIC calls as patching ICs. port 001926cdeca5fe1882cb017c102ffb8bfc42dd04 (r40163) original commit message: In fullcodegen we used to count CallICs as patching ICs, and thus the heuristics are currently off by the number of calls in a code object. BUG= Committed: https://crrev.com/5c9d0ac9c14a07953a046e0a22fe05dadeeb24e8 Cr-Commit-Position: refs/heads/master@{#40199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-12 05:41:33 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-12 06:50:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406373004/1
4 years, 2 months ago (2016-10-12 07:01:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406373004/1
4 years, 2 months ago (2016-10-12 07:37:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 07:39:24 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 07:39:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c9d0ac9c14a07953a046e0a22fe05dadeeb24e8
Cr-Commit-Position: refs/heads/master@{#40199}

Powered by Google App Engine
This is Rietveld 408576698