Small: Delay checksum only on ReadFromDisk, not in FullUpdate cases

Delay checksum only on ReadFromDisk, not in FullUpdate cases
Existing code was delaying checksum check when the |old_prefixes_map|
was empty. However, this is also the case when we receive a FULL_UPDATE
response from the server. We call:
ProcessUpdate(HashPrefixMap(), response)
So checking for an empty |old_prefixes_map| is an incorrect condition.

This CL adds a flag: |delay_checksum_check| which is set to true only in
ReadFromDisk method.

BUG=543161, 651911
Committed: https://crrev.com/cfa3d9220463fcc9b19f3fe6c9c3a3a2a030b76e
Cr-Commit-Position: refs/heads/master@{#425531}

[vakh (use Gerrit instead), 2016-10-12 00:00:50]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[vakh (use Gerrit instead), 2016-10-12 00:01:38]

vakh@chromium.org changed reviewers:
+ nparker@chromium.org

[commit-bot: I haz the power, 2016-10-12 00:01:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 01:01:01]

Dry run: This issue passed the CQ dry run.

[vakh (use Gerrit instead), 2016-10-14 18:09:53]

vakh@chromium.org changed reviewers:
+ shess@chromium.org

[vakh (use Gerrit instead), 2016-10-14 18:09:54]

Ping.

[Nathan Parker, 2016-10-14 23:49:38]

lgtm

https://codereview.chromium.org/2406373003/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_store.cc (right):

https://codereview.chromium.org/2406373003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_store.cc:192: ProcessUpdate(hash_prefix_map_old,
response, false);
nit: false /* delay_checksum check */ )

https://codereview.chromium.org/2406373003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_store.cc:468: if (delay_checksum_check) {
A thought: I kinda feel like this block could be removed from mergeUpdate and
put directly into ProcessUpdate (or another func), since it really isn't merging
an update.

https://codereview.chromium.org/2406373003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_store.cc:641: ApplyUpdateResult
apply_update_result = ProcessFullUpdate(response, true);
true /* delay_checksum_check */

[vakh (use Gerrit instead), 2016-10-15 00:24:21]

nparker@ review. Move delay_checksum_check into ProcessUpdate

[vakh (use Gerrit instead), 2016-10-15 00:24:23]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 00:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:33:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vakh (use Gerrit instead), 2016-10-15 00:39:43]

rebase

[vakh (use Gerrit instead), 2016-10-15 00:39:45]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:40:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 00:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:48:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vakh (use Gerrit instead), 2016-10-15 00:50:59]

Remove extra bool argument from MergeUpdate calls in tests

[vakh (use Gerrit instead), 2016-10-15 00:51:01]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-10-15 00:51:01]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2406373003/#ps60001
(title: "Remove extra bool argument from MergeUpdate calls in tests")

[commit-bot: I haz the power, 2016-10-15 00:51:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 01:44:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-15 01:47:18]

Description was changed from

==========
Delay checksum only on ReadFromDisk, not in FullUpdate cases
Existing code was delaying checksum check when the |old_prefixes_map|
was empty. However, this is also the case when we receive a FULL_UPDATE
response from the server. We call:
ProcessUpdate(HashPrefixMap(), response)
So checking for an empty |old_prefixes_map| is an incorrect condition.

This CL adds a flag: |delay_checksum_check| which is set to true only in
ReadFromDisk method.

BUG=543161, 651911
==========

to

==========
Delay checksum only on ReadFromDisk, not in FullUpdate cases
Existing code was delaying checksum check when the |old_prefixes_map|
was empty. However, this is also the case when we receive a FULL_UPDATE
response from the server. We call:
ProcessUpdate(HashPrefixMap(), response)
So checking for an empty |old_prefixes_map| is an incorrect condition.

This CL adds a flag: |delay_checksum_check| which is set to true only in
ReadFromDisk method.

BUG=543161, 651911

Committed: https://crrev.com/cfa3d9220463fcc9b19f3fe6c9c3a3a2a030b76e
Cr-Commit-Position: refs/heads/master@{#425531}
==========

[commit-bot: I haz the power, 2016-10-15 01:47:19]

Patchset 4 (id:??) landed as
https://crrev.com/cfa3d9220463fcc9b19f3fe6c9c3a3a2a030b76e
Cr-Commit-Position: refs/heads/master@{#425531}