Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issue 2406363005: test_runner: Suppress validation messages on WPTServe too. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
kojii
CC:
blink-reviews, chromium-reviews, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

test_runner: Suppress validation messages on WPTServe too. Form validation messages are suppressed for web-platform-tests since [1]. However is_web_platform_tests_mode() returned false for tests served from WPTServe. [1] https://codereview.chromium.org/2385063002/ BUG=653859 Committed: https://crrev.com/d37f3cfb0ba4ed0a4ad4253b39a2c8122306862f Cr-Commit-Position: refs/heads/master@{#424951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/test_runner/test_interfaces.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/WPTServeExpectations View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
kojii@, would you review this please?
4 years, 2 months ago (2016-10-13 02:02:04 UTC) #4
kojii
lgtm
4 years, 2 months ago (2016-10-13 03:20:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406363005/1
4 years, 2 months ago (2016-10-13 03:47:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 03:53:07 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 03:55:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d37f3cfb0ba4ed0a4ad4253b39a2c8122306862f
Cr-Commit-Position: refs/heads/master@{#424951}

Powered by Google App Engine
This is Rietveld 408576698