Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: ui/views/controls/focus_ring.h

Issue 2406363003: Update appearance of invalid textfields in Harmony. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/focus_ring.h
diff --git a/ui/views/controls/focus_ring.h b/ui/views/controls/focus_ring.h
index 2438bc7b9dd5f215359deddab148669cc2f798a6..26fc5b8e7a1559fa92a20d05a620ef87f55905b5 100644
--- a/ui/views/controls/focus_ring.h
+++ b/ui/views/controls/focus_ring.h
@@ -5,6 +5,8 @@
#ifndef UI_VIEWS_CONTROLS_FOCUS_RING_H_
#define UI_VIEWS_CONTROLS_FOCUS_RING_H_
+#include "base/optional.h"
+#include "ui/native_theme/native_theme.h"
#include "ui/views/view.h"
namespace views {
@@ -14,12 +16,19 @@ namespace views {
// the bounds of its parent view.
class FocusRing : public View {
public:
+ static const char kViewClassName[];
+
// Create a FocusRing and adds it to |parent|.
static void Install(views::View* parent);
// Removes the FocusRing from |parent|.
static void Uninstall(views::View* parent);
+ // FIXME
sky 2016/10/11 23:59:18 ?
Evan Stade 2016/10/12 00:36:38 oops, supposed to be a note to myself to add docs.
+ static void SetColorId(
sky 2016/10/11 23:59:18 WDYT of making the override_color_id an optional p
Evan Stade 2016/10/12 00:36:38 sure, done. I got rid of base::Optional because it
+ views::View* parent,
+ const base::Optional<ui::NativeTheme::ColorId>& override_color_id);
+
// View:
const char* GetClassName() const override;
bool CanProcessEventsWithinSubtree() const override;
@@ -27,11 +36,11 @@ class FocusRing : public View {
void OnPaint(gfx::Canvas* canvas) override;
private:
- static const char kViewClassName[];
-
FocusRing();
~FocusRing() override;
+ base::Optional<ui::NativeTheme::ColorId> override_color_id_;
+
DISALLOW_COPY_AND_ASSIGN(FocusRing);
};

Powered by Google App Engine
This is Rietveld 408576698