Update appearance of invalid textfields in Harmony.

Update appearance of invalid textfields in Harmony.

BUG=650875
Committed: https://crrev.com/f874b12b12f0778a453b5cd37cfe2f29d3df1c6e
Cr-Commit-Position: refs/heads/master@{#425341}

[Evan Stade, 2016-10-11 22:58:50]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 22:59:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-10-11 23:41:02]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-10-11 23:59:18]

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/focus_ring.h
File ui/views/controls/focus_ring.h (right):

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/focus_rin...
ui/views/controls/focus_ring.h:27: // FIXME
?

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/focus_rin...
ui/views/controls/focus_ring.h:28: static void SetColorId(
WDYT of making the override_color_id an optional parameter to Install? That way
it's clearer the FocusRing has to be there.

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/textfield...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/textfield...
ui/views/controls/textfield/textfield.cc:1837:
std::unique_ptr<views::FocusableBorder> border(new views::FocusableBorder());
MakeUnique

[commit-bot: I haz the power, 2016-10-12 00:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 00:03:30]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-10-12 00:36:39]

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/focus_ring.h
File ui/views/controls/focus_ring.h (right):

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/focus_rin...
ui/views/controls/focus_ring.h:27: // FIXME
On 2016/10/11 23:59:18, sky wrote:
> ?

oops, supposed to be a note to myself to add docs.

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/focus_rin...
ui/views/controls/focus_ring.h:28: static void SetColorId(
On 2016/10/11 23:59:18, sky wrote:
> WDYT of making the override_color_id an optional parameter to Install? That
way
> it's clearer the FocusRing has to be there.

sure, done. I got rid of base::Optional because it made it hard to use
ternaries:

error: incompatible operand types ('ui::NativeTheme::ColorId' and 'const
base::nullopt_t')

luckily since it's an enum there's already a reserved, unused value.

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/textfield...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/2406363003/diff/1/ui/views/controls/textfield...
ui/views/controls/textfield/textfield.cc:1837:
std::unique_ptr<views::FocusableBorder> border(new views::FocusableBorder());
On 2016/10/11 23:59:18, sky wrote:
> MakeUnique

Done.

[Evan Stade, 2016-10-12 00:36:45]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 00:37:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 01:42:42]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-12 15:48:35]

LGTM

[Evan Stade, 2016-10-14 14:55:26]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-10-14 14:55:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 16:03:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 16:04:53]

Description was changed from

==========
Update appearance of invalid textfields in Harmony.

BUG=650875
==========

to

==========
Update appearance of invalid textfields in Harmony.

BUG=650875

Committed: https://crrev.com/f874b12b12f0778a453b5cd37cfe2f29d3df1c6e
Cr-Commit-Position: refs/heads/master@{#425341}
==========

[commit-bot: I haz the power, 2016-10-14 16:04:54]

Patchset 2 (id:??) landed as
https://crrev.com/f874b12b12f0778a453b5cd37cfe2f29d3df1c6e
Cr-Commit-Position: refs/heads/master@{#425341}