Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2406363002: [heap] Use size_t in free list and evacuation candidate selection. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use size_t in free list and evacuation candidate selection. BUG=chromium:652721 Committed: https://crrev.com/5831264356d44bf3f6a87e671622d163e586747e Cr-Commit-Position: refs/heads/master@{#40250}

Patch Set 1 : dcheck #

Patch Set 2 : fix dcheck #

Patch Set 3 : Fix SimulateFullSpace #

Patch Set 4 : fix name #

Patch Set 5 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -148 lines) Patch
M src/globals.h View 1 chunk +12 lines, -11 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 13 chunks +27 lines, -23 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 14 chunks +76 lines, -68 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 28 chunks +59 lines, -44 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
ulan
ptal
4 years, 2 months ago (2016-10-12 12:22:05 UTC) #9
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-12 12:28:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406363002/140001
4 years, 2 months ago (2016-10-12 12:36:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/16022) v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-12 12:56:44 UTC) #14
Michael Lippautz
still lgtm
4 years, 2 months ago (2016-10-13 08:27:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406363002/180001
4 years, 2 months ago (2016-10-13 08:41:17 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/10253) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-13 08:44:08 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406363002/200001
4 years, 2 months ago (2016-10-13 10:22:45 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:200001)
4 years, 2 months ago (2016-10-13 10:50:45 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 10:50:59 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5831264356d44bf3f6a87e671622d163e586747e
Cr-Commit-Position: refs/heads/master@{#40250}

Powered by Google App Engine
This is Rietveld 408576698