[promises] Move PromiseReactionJob to c++

src/objects-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include "src/bootstrapper.h"
 #include "src/disasm.h"
 #include "src/disassembler.h"
 #include "src/field-type.h"
@@ skipping 904 matching lines @@
 void PromiseContainer::PromiseContainerVerify() {
   CHECK(IsPromiseContainer());
   thenable()->ObjectVerify();
   then()->ObjectVerify();
   resolve()->ObjectVerify();
   reject()->ObjectVerify();
   before_debug_event()->ObjectVerify();
   after_debug_event()->ObjectVerify();
 }
 
+void PromiseHandleInfo::PromiseHandleInfoVerify() {
+  CHECK(IsPromiseHandleInfo());
+  value()->ObjectVerify();
+  tasks()->ObjectVerify();
+  deferred()->ObjectVerify();
+  before_debug_event()->ObjectVerify();
+  after_debug_event()->ObjectVerify();
+  reaction_context()->ObjectVerify();

[adamk, 2016/10/11 23:14:30]

I think I led you down the wrong path here the first time (still waiting for a
response on v8-dev to be sure). But I think the only checks you want here are
that fields are of the right type, e.g.,

CHECK(tasks()->IsJSArray() || tasks()->IsCallable())

[gsathya, 2016/10/12 02:00:44]

Why is tasks special? Don't we want to check if deferred is Undefined or
callable too?

+}
+
 void JSModuleNamespace::JSModuleNamespaceVerify() {
   CHECK(IsJSModuleNamespace());
   module()->ObjectVerify();
 }
 
 void Module::ModuleVerify() {
   Isolate* isolate = GetIsolate();
   CHECK(IsModule());
   CHECK(code()->IsSharedFunctionInfo() || code()->IsJSFunction());
   code()->ObjectVerify();
@@ skipping 438 matching lines @@
 
   // Both are done at the same time.
   CHECK_EQ(new_it.done(), old_it.done());
 }
 
 
 #endif  // DEBUG
 
 }  // namespace internal
 }  // namespace v8