Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 240633003: add some asserts for mipmaps, and cleanup fFilterLevel if mipping failed (Closed)

Created:
6 years, 8 months ago by reed1
Modified:
6 years, 8 months ago
Reviewers:
humper, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add some asserts for mipmaps, and cleanup fFilterLevel if mipping failed BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14241

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/core/SkBitmapProcState.cpp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
investigating https://code.google.com/p/chromium/issues/detail?id=362154 , so just trying to harden this code.
6 years, 8 months ago (2014-04-17 15:15:16 UTC) #1
scroggo
On 2014/04/17 15:15:16, reed1 wrote: > investigating https://code.google.com/p/chromium/issues/detail?id=362154 , so > just trying to harden ...
6 years, 8 months ago (2014-04-17 15:34:48 UTC) #2
reed1
https://codereview.chromium.org/240633003/diff/20001/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/240633003/diff/20001/src/core/SkBitmapProcState.cpp#newcode407 src/core/SkBitmapProcState.cpp:407: // If we are "still" kMedium_FilterLeve, then then request ...
6 years, 8 months ago (2014-04-17 15:40:13 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 8 months ago (2014-04-17 15:40:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/240633003/40001
6 years, 8 months ago (2014-04-17 15:40:34 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 16:46:09 UTC) #6
Message was sent while issue was closed.
Change committed as 14241

Powered by Google App Engine
This is Rietveld 408576698