ui/views/controls/button/custom_button.cc - Issue 2406323002: CustomButton: restrict animation repaints to buttons that actually animate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/custom_button.cc

Issue 2406323002: CustomButton: restrict animation repaints to buttons that actually animate (Closed)

Patch Set: CustomButton: restrict animation repaints to buttons that actually animate Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/custom_button.cc

diff --git a/ui/views/controls/button/custom_button.cc b/ui/views/controls/button/custom_button.cc

index 5bcd0c907fc2107e111dbfafed4adb36e43843ef..19c7f0125c18c7cbe045f07de71bb44efbf586c1 100644

--- a/ui/views/controls/button/custom_button.cc

+++ b/ui/views/controls/button/custom_button.cc

@@ -365,7 +365,8 @@ SkColor CustomButton::GetInkDropBaseColor() const {

// CustomButton, gfx::AnimationDelegate implementation:

void CustomButton::AnimationProgressed(const gfx::Animation* animation) {

- SchedulePaint();

+ if (animates_hover())

+ SchedulePaint();

}

////////////////////////////////////////////////////////////////////////////////