ash/common/frame/caption_buttons/frame_caption_button.cc - Issue 2406323002: CustomButton: restrict animation repaints to buttons that actually animate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/frame/caption_buttons/frame_caption_button.cc

Issue 2406323002: CustomButton: restrict animation repaints to buttons that actually animate (Closed)

Patch Set: CustomButton: restrict animation repaints to buttons that actually animate Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/frame/caption_buttons/frame_caption_button.cc

diff --git a/ash/common/frame/caption_buttons/frame_caption_button.cc b/ash/common/frame/caption_buttons/frame_caption_button.cc

index eaf494c2cc13acf0c3c3ab8fbe532daeaa90f5c3..24bbbcfbfa1591f3b0f9580dee75d313b25a7a4a 100644

--- a/ash/common/frame/caption_buttons/frame_caption_button.cc

+++ b/ash/common/frame/caption_buttons/frame_caption_button.cc

@@ -44,6 +44,7 @@ FrameCaptionButton::FrameCaptionButton(views::ButtonListener* listener,

use_light_images_(false),

alpha_(255),

swap_images_animation_(new gfx::SlideAnimation(this)) {

+ set_animates_hover(true);

swap_images_animation_->Reset(1);

// Do not flip the gfx::Canvas passed to the OnPaint() method. The snap left