Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Side by Side Diff: chrome/common/features.gni

Issue 2406303003: Move enable_app_list to a buildflag. (Closed)
Patch Set: More grit defines Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/chromecast_build.gni") 6 import("//build/config/chromecast_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 9
10 # Please keep features in alphabetical order. 10 # Please keep features in alphabetical order.
11 declare_args() { 11 declare_args() {
12 # Whether the Java UI is being used (Java infobars and popups, Java native 12 # Whether the Java UI is being used (Java infobars and popups, Java native
13 # settings and first run experience, sign-in etc.). 13 # settings and first run experience, sign-in etc.).
14 # Default to true if compiling for android, but allow this being overriden 14 # Default to true if compiling for android, but allow this being overriden
15 # through the environment. 15 # through the environment.
16 android_java_ui = is_android 16 android_java_ui = is_android
17 17
18 enable_app_list = is_chromeos
19
18 # Enables support for background apps. 20 # Enables support for background apps.
19 enable_background = !is_ios && !is_android && !is_chromecast 21 enable_background = !is_ios && !is_android && !is_chromecast
20 22
21 # Enable the printing system dialog for platforms that support printing 23 # Enable the printing system dialog for platforms that support printing
22 # and have a system dialog. 24 # and have a system dialog.
23 enable_basic_print_dialog = enable_basic_printing && !is_chromeos 25 enable_basic_print_dialog = enable_basic_printing && !is_chromeos
24 26
25 enable_captive_portal_detection = !is_android && !is_ios && !is_chromecast 27 enable_captive_portal_detection = !is_android && !is_ios && !is_chromecast
26 28
27 # Google Now is disabled to prepare for its removal. 29 # Google Now is disabled to prepare for its removal.
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 61
60 # Indicates if the build is using PGO. 62 # Indicates if the build is using PGO.
61 pgo_build = chrome_pgo_phase > 0 63 pgo_build = chrome_pgo_phase > 0
62 64
63 # Use vulcanized HTML/CSS/JS resources to speed up WebUI (chrome://) 65 # Use vulcanized HTML/CSS/JS resources to speed up WebUI (chrome://)
64 # pages. https://github.com/polymer/vulcanize 66 # pages. https://github.com/polymer/vulcanize
65 use_vulcanize = true 67 use_vulcanize = true
66 } 68 }
67 69
68 chrome_grit_defines = [ 70 chrome_grit_defines = [
71 "enable_app_list=$enable_app_list",
69 "enable_background=$enable_background", 72 "enable_background=$enable_background",
70 "enable_google_now=$enable_google_now", 73 "enable_google_now=$enable_google_now",
71 "enable_hotwording=$enable_hotwording", 74 "enable_hotwording=$enable_hotwording",
72 "enable_service_discovery=$enable_service_discovery", 75 "enable_service_discovery=$enable_service_discovery",
73 "enable_vr_shell=$enable_vr_shell", 76 "enable_vr_shell=$enable_vr_shell",
74 "enable_webvr=$enable_webvr", 77 "enable_webvr=$enable_webvr",
75 "safe_browsing_mode=$safe_browsing_mode", 78 "safe_browsing_mode=$safe_browsing_mode",
76 "use_vulcanize=$use_vulcanize", 79 "use_vulcanize=$use_vulcanize",
77 ] 80 ]
OLDNEW
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698