Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2406303003: Move enable_app_list to a buildflag. (Closed)
Patch Set: More grit defines Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/theme/BUILD.gn ('k') | chrome/browser/chromeos/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 #if defined(OS_CHROMEOS) 91 #if defined(OS_CHROMEOS)
92 #include "chromeos/chromeos_switches.h" 92 #include "chromeos/chromeos_switches.h"
93 #include "components/arc/arc_features.h" 93 #include "components/arc/arc_features.h"
94 #include "third_party/cros_system_api/switches/chrome_switches.h" 94 #include "third_party/cros_system_api/switches/chrome_switches.h"
95 #endif // OS_CHROMEOS 95 #endif // OS_CHROMEOS
96 96
97 #if defined(OS_MACOSX) 97 #if defined(OS_MACOSX)
98 #include "chrome/browser/ui/browser_dialogs.h" 98 #include "chrome/browser/ui/browser_dialogs.h"
99 #endif // OS_MACOSX 99 #endif // OS_MACOSX
100 100
101 #if defined(ENABLE_APP_LIST) 101 #if BUILDFLAG(ENABLE_APP_LIST)
102 #include "ui/app_list/app_list_switches.h" 102 #include "ui/app_list/app_list_switches.h"
103 #endif // ENABLE_APP_LIST 103 #endif // ENABLE_APP_LIST
104 104
105 #if defined(ENABLE_EXTENSIONS) 105 #if defined(ENABLE_EXTENSIONS)
106 #include "extensions/common/switches.h" 106 #include "extensions/common/switches.h"
107 #endif // ENABLE_EXTENSIONS 107 #endif // ENABLE_EXTENSIONS
108 108
109 #if defined(USE_ASH) 109 #if defined(USE_ASH)
110 #include "ash/common/ash_switches.h" 110 #include "ash/common/ash_switches.h"
111 #endif // USE_ASH 111 #endif // USE_ASH
(...skipping 926 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 SINGLE_VALUE_TYPE( 1038 SINGLE_VALUE_TYPE(
1039 autofill::switches::kEnableSuggestionsWithSubstringMatch)}, 1039 autofill::switches::kEnableSuggestionsWithSubstringMatch)},
1040 {"enable-speculative-launch-service-worker", 1040 {"enable-speculative-launch-service-worker",
1041 IDS_FLAGS_SPECULATIVE_LAUNCH_SERVICE_WORKER_NAME, 1041 IDS_FLAGS_SPECULATIVE_LAUNCH_SERVICE_WORKER_NAME,
1042 IDS_FLAGS_SPECULATIVE_LAUNCH_SERVICE_WORKER_DESCRIPTION, kOsAll, 1042 IDS_FLAGS_SPECULATIVE_LAUNCH_SERVICE_WORKER_DESCRIPTION, kOsAll,
1043 FEATURE_VALUE_TYPE(features::kSpeculativeLaunchServiceWorker)}, 1043 FEATURE_VALUE_TYPE(features::kSpeculativeLaunchServiceWorker)},
1044 {"enable-supervised-user-managed-bookmarks-folder", 1044 {"enable-supervised-user-managed-bookmarks-folder",
1045 IDS_FLAGS_SUPERVISED_USER_MANAGED_BOOKMARKS_FOLDER_NAME, 1045 IDS_FLAGS_SUPERVISED_USER_MANAGED_BOOKMARKS_FOLDER_NAME,
1046 IDS_FLAGS_SUPERVISED_USER_MANAGED_BOOKMARKS_FOLDER_DESCRIPTION, kOsAll, 1046 IDS_FLAGS_SUPERVISED_USER_MANAGED_BOOKMARKS_FOLDER_DESCRIPTION, kOsAll,
1047 SINGLE_VALUE_TYPE(switches::kEnableSupervisedUserManagedBookmarksFolder)}, 1047 SINGLE_VALUE_TYPE(switches::kEnableSupervisedUserManagedBookmarksFolder)},
1048 #if defined(ENABLE_APP_LIST) 1048 #if BUILDFLAG(ENABLE_APP_LIST)
1049 {"enable-sync-app-list", IDS_FLAGS_SYNC_APP_LIST_NAME, 1049 {"enable-sync-app-list", IDS_FLAGS_SYNC_APP_LIST_NAME,
1050 IDS_FLAGS_SYNC_APP_LIST_DESCRIPTION, kOsDesktop, 1050 IDS_FLAGS_SYNC_APP_LIST_DESCRIPTION, kOsDesktop,
1051 ENABLE_DISABLE_VALUE_TYPE(app_list::switches::kEnableSyncAppList, 1051 ENABLE_DISABLE_VALUE_TYPE(app_list::switches::kEnableSyncAppList,
1052 app_list::switches::kDisableSyncAppList)}, 1052 app_list::switches::kDisableSyncAppList)},
1053 #endif // ENABLE_APP_LIST 1053 #endif // ENABLE_APP_LIST
1054 {"lcd-text-aa", IDS_FLAGS_LCD_TEXT_NAME, IDS_FLAGS_LCD_TEXT_DESCRIPTION, 1054 {"lcd-text-aa", IDS_FLAGS_LCD_TEXT_NAME, IDS_FLAGS_LCD_TEXT_DESCRIPTION,
1055 kOsDesktop, ENABLE_DISABLE_VALUE_TYPE(switches::kEnableLCDText, 1055 kOsDesktop, ENABLE_DISABLE_VALUE_TYPE(switches::kEnableLCDText,
1056 switches::kDisableLCDText)}, 1056 switches::kDisableLCDText)},
1057 {"enable-offer-store-unmasked-wallet-cards", 1057 {"enable-offer-store-unmasked-wallet-cards",
1058 IDS_FLAGS_OFFER_STORE_UNMASKED_WALLET_CARDS, 1058 IDS_FLAGS_OFFER_STORE_UNMASKED_WALLET_CARDS,
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
1190 kOsMac | kOsWin | kOsLinux, 1190 kOsMac | kOsWin | kOsLinux,
1191 FEATURE_VALUE_TYPE(switches::kMaterialDesignUserManager)}, 1191 FEATURE_VALUE_TYPE(switches::kMaterialDesignUserManager)},
1192 {"show-material-design-user-menu", 1192 {"show-material-design-user-menu",
1193 IDS_FLAGS_SHOW_MATERIAL_DESIGN_USER_MENU_NAME, 1193 IDS_FLAGS_SHOW_MATERIAL_DESIGN_USER_MENU_NAME,
1194 IDS_FLAGS_SHOW_MATERIAL_DESIGN_USER_MENU_DESCRIPTION, 1194 IDS_FLAGS_SHOW_MATERIAL_DESIGN_USER_MENU_DESCRIPTION,
1195 kOsMac | kOsWin | kOsLinux, 1195 kOsMac | kOsWin | kOsLinux,
1196 FEATURE_VALUE_TYPE(switches::kMaterialDesignUserMenu)}, 1196 FEATURE_VALUE_TYPE(switches::kMaterialDesignUserMenu)},
1197 {"enable-google-profile-info", IDS_FLAGS_GOOGLE_PROFILE_INFO_NAME, 1197 {"enable-google-profile-info", IDS_FLAGS_GOOGLE_PROFILE_INFO_NAME,
1198 IDS_FLAGS_GOOGLE_PROFILE_INFO_DESCRIPTION, kOsMac | kOsWin | kOsLinux, 1198 IDS_FLAGS_GOOGLE_PROFILE_INFO_DESCRIPTION, kOsMac | kOsWin | kOsLinux,
1199 SINGLE_VALUE_TYPE(switches::kGoogleProfileInfo)}, 1199 SINGLE_VALUE_TYPE(switches::kGoogleProfileInfo)},
1200 #if defined(ENABLE_APP_LIST) 1200 #if BUILDFLAG(ENABLE_APP_LIST)
1201 {"reset-app-list-install-state", 1201 {"reset-app-list-install-state",
1202 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME, 1202 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_NAME,
1203 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION, 1203 IDS_FLAGS_RESET_APP_LIST_INSTALL_STATE_DESCRIPTION,
1204 kOsMac | kOsWin | kOsLinux, 1204 kOsMac | kOsWin | kOsLinux,
1205 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)}, 1205 SINGLE_VALUE_TYPE(app_list::switches::kResetAppListInstallState)},
1206 #endif // ENABLE_APP_LIST 1206 #endif // ENABLE_APP_LIST
1207 #if defined(OS_ANDROID) 1207 #if defined(OS_ANDROID)
1208 {"enable-downloads-ui", IDS_FLAGS_ENABLE_DOWNLOADS_UI_NAME, 1208 {"enable-downloads-ui", IDS_FLAGS_ENABLE_DOWNLOADS_UI_NAME,
1209 IDS_FLAGS_ENABLE_DOWNLOADS_UI_DESCRIPTION, kOsAndroid, 1209 IDS_FLAGS_ENABLE_DOWNLOADS_UI_DESCRIPTION, kOsAndroid,
1210 FEATURE_VALUE_TYPE(chrome::android::kDownloadsUiFeature)}, 1210 FEATURE_VALUE_TYPE(chrome::android::kDownloadsUiFeature)},
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
1515 #if defined(ENABLE_MEDIA_ROUTER) && !defined(OS_ANDROID) 1515 #if defined(ENABLE_MEDIA_ROUTER) && !defined(OS_ANDROID)
1516 {"media-router", IDS_FLAGS_MEDIA_ROUTER_NAME, 1516 {"media-router", IDS_FLAGS_MEDIA_ROUTER_NAME,
1517 IDS_FLAGS_MEDIA_ROUTER_DESCRIPTION, kOsDesktop, 1517 IDS_FLAGS_MEDIA_ROUTER_DESCRIPTION, kOsDesktop,
1518 ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(switches::kMediaRouter, 1518 ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(switches::kMediaRouter,
1519 "1", 1519 "1",
1520 switches::kMediaRouter, 1520 switches::kMediaRouter,
1521 "0")}, 1521 "0")},
1522 #endif // ENABLE_MEDIA_ROUTER) && !defined(OS_ANDROID 1522 #endif // ENABLE_MEDIA_ROUTER) && !defined(OS_ANDROID
1523 // Since Drive Search is not available when app list is disabled, flag guard 1523 // Since Drive Search is not available when app list is disabled, flag guard
1524 // enable-drive-search-in-chrome-launcher flag. 1524 // enable-drive-search-in-chrome-launcher flag.
1525 #if defined(ENABLE_APP_LIST) 1525 #if BUILDFLAG(ENABLE_APP_LIST)
1526 {"enable-drive-search-in-app-launcher", 1526 {"enable-drive-search-in-app-launcher",
1527 IDS_FLAGS_DRIVE_SEARCH_IN_CHROME_LAUNCHER, 1527 IDS_FLAGS_DRIVE_SEARCH_IN_CHROME_LAUNCHER,
1528 IDS_FLAGS_DRIVE_SEARCH_IN_CHROME_LAUNCHER_DESCRIPTION, kOsCrOS, 1528 IDS_FLAGS_DRIVE_SEARCH_IN_CHROME_LAUNCHER_DESCRIPTION, kOsCrOS,
1529 ENABLE_DISABLE_VALUE_TYPE( 1529 ENABLE_DISABLE_VALUE_TYPE(
1530 app_list::switches::kEnableDriveSearchInChromeLauncher, 1530 app_list::switches::kEnableDriveSearchInChromeLauncher,
1531 app_list::switches::kDisableDriveSearchInChromeLauncher)}, 1531 app_list::switches::kDisableDriveSearchInChromeLauncher)},
1532 #endif // ENABLE_APP_LIST 1532 #endif // ENABLE_APP_LIST
1533 #if defined(OS_CHROMEOS) 1533 #if defined(OS_CHROMEOS)
1534 {"disable-mtp-write-support", IDS_FLAGS_MTP_WRITE_SUPPORT_NAME, 1534 {"disable-mtp-write-support", IDS_FLAGS_MTP_WRITE_SUPPORT_NAME,
1535 IDS_FLAGS_MTP_WRITE_SUPPORT_DESCRIPTION, kOsCrOS, 1535 IDS_FLAGS_MTP_WRITE_SUPPORT_DESCRIPTION, kOsCrOS,
(...skipping 697 matching lines...) Expand 10 before | Expand all | Expand 10 after
2233 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2233 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2234 2234
2235 const FeatureEntry* GetFeatureEntries(size_t* count) { 2235 const FeatureEntry* GetFeatureEntries(size_t* count) {
2236 *count = arraysize(kFeatureEntries); 2236 *count = arraysize(kFeatureEntries);
2237 return kFeatureEntries; 2237 return kFeatureEntries;
2238 } 2238 }
2239 2239
2240 } // namespace testing 2240 } // namespace testing
2241 2241
2242 } // namespace about_flags 2242 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/theme/BUILD.gn ('k') | chrome/browser/chromeos/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698