Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24063002: PowerPC is not supported by blink (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

PowerPC cpu is not supported by blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/core/platform/audio/DirectConvolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/audio/VectorMath.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lgombos
CPU(PPC) has been just removed from CPU.h as well - see https://chromiumcodereview.appspot.com/23444030 .
7 years, 3 months ago (2013-09-08 16:22:42 UTC) #1
abarth-chromium
We should have someone familiar with this code review this CL.
7 years, 3 months ago (2013-09-08 17:09:21 UTC) #2
lgombos
Chris, what do you think ?
7 years, 3 months ago (2013-09-08 19:26:36 UTC) #3
lgombos
Adding Kenneth to the reviewers list. Kenneth, what do you think ?
7 years, 3 months ago (2013-09-09 14:29:11 UTC) #4
Ken Russell (switch to Gerrit)
+rtoy, -crogers These changes seem straightforward. LGTM
7 years, 3 months ago (2013-09-09 16:38:26 UTC) #5
Raymond Toy (Google)
On 2013/09/09 16:38:26, Ken Russell wrote: > +rtoy, -crogers > > These changes seem straightforward. ...
7 years, 3 months ago (2013-09-09 16:49:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/24063002/1
7 years, 3 months ago (2013-09-09 20:09:09 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 21:37:59 UTC) #8
Message was sent while issue was closed. 
Change committed as 157476

Powered by Google App Engine
This is Rietveld 408576698