components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java - Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test (Closed)

Patch Set: fix shutdown race Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/sdch_test_util.cc ('k') | components/cronet/android/test/src/org/chromium/net/CronetTestUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

diff --git a/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java b/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

index 283abad90b7116cbc9825741239491bc04e3326d..cc2a46302ad6ffa4c81f04321bd8a1a750a393e5 100644

--- a/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

+++ b/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

@@ -195,8 +195,6 @@ public class CronetTestFramework {

cronetEngineBuilder.enableSdch(true);

}

- // Setting this here so it isn't overridden on the command line

- CronetTestUtil.setLibraryName(cronetEngineBuilder, "cronet_tests");

return cronetEngineBuilder;

}