Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test (Closed)
Patch Set: fix shutdown race Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
index e50b9000c4f098fc3c18876d9b5d55b2cf5f0d22..1a900891f4df3e3d721ad399cefce22f89f7332d 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
@@ -40,6 +40,7 @@ public class CronetUrlRequestTest extends CronetTestBase {
private static final String TEST_URL = "http://127.0.0.1:8000";
private CronetTestFramework mTestFramework;
+ private MockUrlRequestJobFactory mMockUrlRequestJobFactory;
@Override
protected void setUp() throws Exception {
@@ -47,11 +48,12 @@ public class CronetUrlRequestTest extends CronetTestBase {
mTestFramework = startCronetTestFramework();
assertTrue(NativeTestServer.startNativeTestServer(getContext()));
// Add url interceptors after native application context is initialized.
- MockUrlRequestJobFactory.setUp();
+ mMockUrlRequestJobFactory = new MockUrlRequestJobFactory(mTestFramework.mCronetEngine);
}
@Override
protected void tearDown() throws Exception {
+ mMockUrlRequestJobFactory.shutdown();
NativeTestServer.shutdownNativeTestServer();
mTestFramework.mCronetEngine.shutdown();
super.tearDown();

Powered by Google App Engine
This is Rietveld 408576698