Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: components/cronet/android/test/src/org/chromium/net/TestUploadDataStreamHandler.java

Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test (Closed)
Patch Set: address two remaining comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/src/org/chromium/net/TestUploadDataStreamHandler.java
diff --git a/components/cronet/android/test/src/org/chromium/net/TestUploadDataStreamHandler.java b/components/cronet/android/test/src/org/chromium/net/TestUploadDataStreamHandler.java
index 0d2e6100869a29f4cc2a5857b5b707a77428030e..9cce55b35a2fe590441c6999bb17d2bc630a8cd0 100644
--- a/components/cronet/android/test/src/org/chromium/net/TestUploadDataStreamHandler.java
+++ b/components/cronet/android/test/src/org/chromium/net/TestUploadDataStreamHandler.java
@@ -4,6 +4,7 @@
package org.chromium.net;
+import android.content.Context;
import android.os.ConditionVariable;
import junit.framework.Assert;
@@ -11,6 +12,7 @@ import junit.framework.Assert;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeClassQualifiedName;
+import org.chromium.net.impl.CronetUrlRequestContext;
/**
* A wrapper class on top of the native net::UploadDataStream. This class is
@@ -18,6 +20,8 @@ import org.chromium.base.annotations.NativeClassQualifiedName;
*/
@JNINamespace("cronet")
public final class TestUploadDataStreamHandler {
+ private final CronetTestUtil.PrepareNetworkThread mPrepareNetworkThread;
+ private final CronetEngine mCronetEngine;
private long mTestUploadDataStreamHandler;
private ConditionVariable mWaitInitCalled = new ConditionVariable();
private ConditionVariable mWaitInitComplete = new ConditionVariable();
@@ -31,15 +35,20 @@ public final class TestUploadDataStreamHandler {
private boolean mInitCompletedSynchronously = false;
private String mData = "";
- public TestUploadDataStreamHandler(final long uploadDataStream) {
- mTestUploadDataStreamHandler =
- nativeCreateTestUploadDataStreamHandler(uploadDataStream);
+ public TestUploadDataStreamHandler(Context context, final long uploadDataStream) {
+ mCronetEngine = new CronetEngine.Builder(context).build();
+ mPrepareNetworkThread = new CronetTestUtil.PrepareNetworkThread(mCronetEngine);
+ CronetUrlRequestContext requestContext = (CronetUrlRequestContext) mCronetEngine;
+ mTestUploadDataStreamHandler = nativeCreateTestUploadDataStreamHandler(
+ uploadDataStream, requestContext.getUrlRequestContextAdapter());
}
public void destroyNativeObjects() {
if (mTestUploadDataStreamHandler != 0) {
nativeDestroy(mTestUploadDataStreamHandler);
mTestUploadDataStreamHandler = 0;
+ mPrepareNetworkThread.shutdown();
+ mCronetEngine.shutdown();
}
}
@@ -168,5 +177,5 @@ public final class TestUploadDataStreamHandler {
private native void nativeDestroy(long nativePtr);
private native long nativeCreateTestUploadDataStreamHandler(
- long uploadDataStream);
+ long uploadDataStream, long contextAdapter);
}

Powered by Google App Engine
This is Rietveld 408576698