Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java

Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test (Closed)
Patch Set: address two remaining comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java
index fa7a540b1c79845c268d99ea43bf18d4f4dc3f4d..676a66dbddc04eda45c0eb87864e4e42ef1424ca 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java
@@ -25,6 +25,7 @@ public class UploadDataProvidersTest extends CronetTestBase {
private CronetTestFramework mTestFramework;
private File mFile;
private StrictMode.VmPolicy mOldVmPolicy;
+ private MockUrlRequestJobFactory mMockUrlRequestJobFactory;
@Override
protected void setUp() throws Exception {
@@ -38,7 +39,7 @@ public class UploadDataProvidersTest extends CronetTestBase {
mTestFramework = startCronetTestFramework();
assertTrue(NativeTestServer.startNativeTestServer(getContext()));
// Add url interceptors after native application context is initialized.
- MockUrlRequestJobFactory.setUp();
+ mMockUrlRequestJobFactory = new MockUrlRequestJobFactory(mTestFramework.mCronetEngine);
mFile = new File(getContext().getCacheDir().getPath() + "/tmpfile");
FileOutputStream fileOutputStream = new FileOutputStream(mFile);
try {
@@ -52,6 +53,7 @@ public class UploadDataProvidersTest extends CronetTestBase {
@Override
protected void tearDown() throws Exception {
try {
+ mMockUrlRequestJobFactory.shutdown();
NativeTestServer.shutdownNativeTestServer();
mTestFramework.mCronetEngine.shutdown();
assertTrue(mFile.delete());

Powered by Google App Engine
This is Rietveld 408576698