Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: components/cronet/android/cronet_url_request_adapter.h

Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test (Closed)
Patch Set: address two remaining comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_url_request_adapter.h
diff --git a/components/cronet/android/cronet_url_request_adapter.h b/components/cronet/android/cronet_url_request_adapter.h
index eb442c4caa1cc818a36c70fe32ba752960614c19..d1593aaf524cbe215c2aa0a3269f70800226922e 100644
--- a/components/cronet/android/cronet_url_request_adapter.h
+++ b/components/cronet/android/cronet_url_request_adapter.h
@@ -39,6 +39,7 @@ namespace cronet {
class CronetURLRequestContextAdapter;
class IOBufferWithByteBuffer;
+class TestUtil;
bool CronetUrlRequestAdapterRegisterJni(JNIEnv* env);
@@ -122,9 +123,9 @@ class CronetURLRequestAdapter : public net::URLRequest::Delegate {
void OnResponseStarted(net::URLRequest* request, int net_error) override;
void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
- net::URLRequest* GetURLRequestForTesting();
-
private:
+ friend class TestUtil;
+
void StartOnNetworkThread();
void GetStatusOnNetworkThread(
const base::android::ScopedJavaGlobalRef<jobject>& jstatus_listener_ref)

Powered by Google App Engine
This is Rietveld 408576698