Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: components/cronet/android/test/src/org/chromium/net/SdchObserver.java

Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test (Closed)
Patch Set: fix perf test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/src/org/chromium/net/SdchObserver.java
diff --git a/components/cronet/android/test/src/org/chromium/net/SdchObserver.java b/components/cronet/android/test/src/org/chromium/net/SdchObserver.java
index 8e8fe127baab8542b42cf87bff6798284d80d1b4..7a187088a5feadefc7d87e2512b1996016bf5e4f 100644
--- a/components/cronet/android/test/src/org/chromium/net/SdchObserver.java
+++ b/components/cronet/android/test/src/org/chromium/net/SdchObserver.java
@@ -8,6 +8,7 @@ import android.os.ConditionVariable;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.net.impl.CronetUrlRequestContext;
/**
* Class to watch for Sdch dictionary events. The native implementation
@@ -25,8 +26,14 @@ public class SdchObserver {
* @param targetUrl the target url on which sdch encoding will be used.
* @param contextAdapter the native context adapter to register the observer.
*/
- public SdchObserver(String targetUrl, long contextAdapter) {
- nativeAddSdchObserver(targetUrl, contextAdapter);
+ public SdchObserver(final String targetUrl, final CronetUrlRequestContext engine) {
+ CronetTestUtil.postToNetworkThread(engine, new Runnable() {
+ @Override
+ public void run() {
+ nativeAddSdchObserverOnNetworkThread(
+ targetUrl, engine.getUrlRequestContextForTesting());
+ }
+ });
mAddBlock.block();
mAddBlock.close();
}
@@ -51,5 +58,5 @@ public class SdchObserver {
mAddBlock.open();
}
- private native void nativeAddSdchObserver(String targetUrl, long contextAdapter);
+ private native void nativeAddSdchObserverOnNetworkThread(String targetUrl, long context);
}

Powered by Google App Engine
This is Rietveld 408576698