components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java - Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

Issue 2406273002: [Cronet] Test the libcronet that's shipped, not libcronet_test (Closed)

Patch Set: fix perf test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java ('K') | « components/cronet/android/test/sdch_test_util.cc ('k') | components/cronet/android/test/src/org/chromium/net/CronetTestUtil.java » ('j') | components/cronet/android/test/src/org/chromium/net/CronetTestUtil.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

diff --git a/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java b/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

index 0afb5f065fd517821e72b563eb1618246ed53de0..a8d3f03bddd3cfff24efebd9c11f0a07a7d0624a 100644

--- a/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

+++ b/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java

@@ -194,8 +194,6 @@ public class CronetTestFramework {

cronetEngineBuilder.enableSdch(true);

}

- // Setting this here so it isn't overridden on the command line

- cronetEngineBuilder.setLibraryName("cronet_tests");

return cronetEngineBuilder;

}