[Cronet] Test the libcronet that's shipped, not libcronet_test

net/url_request/url_request_intercepting_job_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_INTERCEPTING_JOB_FACTORY_H_
 #define NET_URL_REQUEST_URL_REQUEST_INTERCEPTING_JOB_FACTORY_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 14 matching lines @@
 // URLRequestInteceptor is given the option of creating a URLRequestJob for each
 // URLRequest. If the interceptor does not create a job, the URLRequest is
 // forwarded to the wrapped URLRequestJobFactory instead.
 //
 // This class is only intended for use in intercepting requests before they
 // are passed on to their default ProtocolHandler.  Each supported scheme should
 // have its own ProtocolHandler.
 class NET_EXPORT URLRequestInterceptingJobFactory
     : public URLRequestJobFactory {
  public:
+  // Takes ownership of |job_factory| and |interceptor|.
   URLRequestInterceptingJobFactory(
       std::unique_ptr<URLRequestJobFactory> job_factory,
       std::unique_ptr<URLRequestInterceptor> interceptor);
+  // Does not take ownership of |job_factory| and |interceptor|.
+  URLRequestInterceptingJobFactory(URLRequestJobFactory* job_factory,

[mef, 2016/11/16 18:45:44]

This is weird and I think deserves a comment WRT why is it needed.

[pauljensen, 2016/11/18 18:12:10]

Done.

+                                   URLRequestInterceptor* interceptor);
   ~URLRequestInterceptingJobFactory() override;
 
   // URLRequestJobFactory implementation
   URLRequestJob* MaybeCreateJobWithProtocolHandler(
       const std::string& scheme,
       URLRequest* request,
       NetworkDelegate* network_delegate) const override;
 
   URLRequestJob* MaybeInterceptRedirect(
       URLRequest* request,
       NetworkDelegate* network_delegate,
       const GURL& location) const override;
 
   URLRequestJob* MaybeInterceptResponse(
       URLRequest* request,
       NetworkDelegate* network_delegate) const override;
 
   bool IsHandledProtocol(const std::string& scheme) const override;
   bool IsHandledURL(const GURL& url) const override;
   bool IsSafeRedirectTarget(const GURL& location) const override;
 
  private:
-  std::unique_ptr<URLRequestJobFactory> job_factory_;
-  std::unique_ptr<URLRequestInterceptor> interceptor_;
+  // |owning_| indicates if this object owns |job_factory_| and |interceptor_|.
+  bool owning_;
+  URLRequestJobFactory* job_factory_;
+  URLRequestInterceptor* interceptor_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestInterceptingJobFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_INTERCEPTING_JOB_FACTORY_H_