[Cronet] Test the libcronet that's shipped, not libcronet_test

components/cronet/android/test/cronet_test_jni.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <jni.h>
 
+#include "base/android/base_jni_onload.h"
 #include "base/android/base_jni_registrar.h"
+#include "base/android/context_utils.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_registrar.h"
+#include "base/android/library_loader/library_loader_hooks.h"
 #include "base/macros.h"
-#include "components/cronet/android/cronet_library_loader.h"
 #include "cronet_test_util.h"
 #include "cronet_url_request_context_config_test.h"
 #include "mock_cert_verifier.h"
 #include "mock_url_request_job_factory.h"
 #include "native_test_server.h"
-#include "network_change_notifier_util.h"
 #include "quic_test_server.h"
 #include "sdch_test_util.h"
 #include "test_upload_data_stream_handler.h"
 
 namespace {
 
 const base::android::RegistrationMethod kCronetTestsRegisteredMethods[] = {
+    {"ContextUtils", base::android::RegisterContextUtils},
     {"MockCertVerifier", cronet::RegisterMockCertVerifier},
     {"MockUrlRequestJobFactory", cronet::RegisterMockUrlRequestJobFactory},
     {"NativeTestServer", cronet::RegisterNativeTestServer},
-    {"NetworkChangeNotifierUtil", cronet::RegisterNetworkChangeNotifierUtil},
     {"QuicTestServer", cronet::RegisterQuicTestServer},
     {"SdchTestUtil", cronet::RegisterSdchTestUtil},
     {"TestUploadDataStreamHandlerRegisterJni",
      cronet::TestUploadDataStreamHandlerRegisterJni},
     {"CronetUrlRequestContextConfigTest",
      cronet::RegisterCronetUrlRequestContextConfigTest},
     {"CronetTestUtil", cronet::RegisterCronetTestUtil},
 };
 
 }  // namespace
 
 // This is called by the VM when the shared library is first loaded.
 // Checks the available version of JNI. Also, caches Java reflection artifacts.
 extern "C" jint JNI_OnLoad(JavaVM* vm, void* reserved) {
   JNIEnv* env;
   if (vm->GetEnv(reinterpret_cast<void**>(&env), JNI_VERSION_1_6) != JNI_OK) {
     return -1;
   }
 
-  jint cronet_onload = cronet::CronetOnLoad(vm, reserved);
-  if (cronet_onload == -1)
-    return cronet_onload;
+  std::vector<base::android::RegisterCallback> register_callbacks;
+  std::vector<base::android::InitCallback> init_callbacks;
+  if (!base::android::OnJNIOnLoadRegisterJNI(vm, register_callbacks) ||

[kapishnikov, 2016/10/20 17:25:46]

Do we need to call this since Cronet::CronetOnLoad() will do it?
|register_callbacks| and |init_callbacks| are empty vectors now. Should we add
an empty cronet_test::RegisterJNI & cronet_test::Init to follow the pattern?

[pauljensen, 2016/10/21 02:27:33]

Yes, we need to call base::android::InitVM() to init libcronet_test.so, and
OnJNIOnLoadRegisterJNI() does this for us.
Adding empty functions doesn't seem purposeful.

+      !base::android::OnJNIOnLoadInit(init_callbacks)) {
+    return -1;
+  }
 
   if (!base::android::RegisterNativeMethods(
           env,
           kCronetTestsRegisteredMethods,
           arraysize(kCronetTestsRegisteredMethods))) {
     return -1;
   }
-  return cronet_onload;
+  return JNI_VERSION_1_6;
 }
 
 extern "C" void JNI_OnUnLoad(JavaVM* vm, void* reserved) {
-  cronet::CronetOnUnLoad(vm, reserved);
+  base::android::LibraryLoaderExitHook();
 }