third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-events.html - Issue 2406263003: Make PointerEvent coordinates fractional for touch

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-events.html

Issue 2406263003: Make PointerEvent coordinates fractional for touch (Closed)

Patch Set: Updated a TODO. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/fast/events/constructors/mouse-event-constructor-expected.txt ('K') | « third_party/WebKit/LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-events-expected.txt » ('j') | third_party/WebKit/Source/core/events/MouseEvent.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <style>	3 <style>

4 div.box {	4 div.box {

5 margin: 10px;	5 margin: 10px;

6 padding: 50px;	6 padding: 50px;

7 float: left;	7 float: left;

8 }	8 }

9 </style>	9 </style>

10	10

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76 var i=0;	76 var i=0;

77 for(var j=0; j<5; j++,i++) {	77 for(var j=0; j<5; j++,i++) {

78 shouldBeTrue("receivedPEsAtTarget["+i+"].isPrimary");	78 shouldBeTrue("receivedPEsAtTarget["+i+"].isPrimary");

79 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].button", 0);	79 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].button", 0);

80 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].buttons", 1);	80 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].buttons", 1);

81 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientX", x);	81 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientX", x);

82 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientY", y);	82 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientY", y);

83 }	83 }

84 shouldBeEqualToNumber("receivedPEsAtTarget.length", i);	84 shouldBeEqualToNumber("receivedPEsAtTarget.length", i);

85	85

86 eventSender.updateTouchPoint(0, x+20, y+20);	86 eventSender.updateTouchPoint(0, x+20.5, y+19.25);

87 eventSender.touchMove();	87 eventSender.touchMove();

88 shouldBeTrue("receivedPEsAtTarget["+i+"].isPrimary");	88 shouldBeTrue("receivedPEsAtTarget["+i+"].isPrimary");

89 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].button", -1);	89 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].button", -1);

90 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].buttons", 1);	90 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].buttons", 1);

91 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientX", x+20);	91 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientX", x+20.5);

92 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientY", y+20);	92 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].clientY", y+19.25);
	Rick Byers 2016/10/13 19:08:21 add test for fractional screen and page co-ordinat add test for fractional screen and page co-ordinates as well. Since the code paths are the same (and pointermove is the important case) I'm fine with testing fractional co-ordinates on just the pointermove event. mustaq 2016/10/14 14:26:58 Done. Show quoted text On 2016/10/13 19:08:21, Rick Byers wrote: > add test for fractional screen and page co-ordinates as well. > > Since the code paths are the same (and pointermove is the important case) I'm > fine with testing fractional co-ordinates on just the pointermove event. Done.
93 shouldBeEqualToNumber("receivedPEsAtTarget.length", ++i);	93 shouldBeEqualToNumber("receivedPEsAtTarget.length", ++i);

94	94

95 eventSender.releaseTouchPoint(0);	95 eventSender.releaseTouchPoint(0);

96 eventSender.touchEnd();	96 eventSender.touchEnd();

97 for(var j=0; j<5; j++,i++) {	97 for(var j=0; j<5; j++,i++) {

98 shouldBeTrue("receivedPEsAtTarget["+i+"].isPrimary");	98 shouldBeTrue("receivedPEsAtTarget["+i+"].isPrimary");

99 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].button", 0);	99 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].button", 0);

100 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].buttons", 0);	100 shouldBeEqualToNumber("receivedPEsAtTarget["+i+"].buttons", 0);

101 }	101 }

102	102

(...skipping 102 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
205 debug("");	205 debug("");

206 }	206 }

207	207

208 init();	208 init();

209 if (window.eventSender)	209 if (window.eventSender)

210 runTests();	210 runTests();

211 else	211 else

212 debug("This test requires eventSender");	212 debug("This test requires eventSender");

213	213

214 </script>	214 </script>

OLD	NEW