Make PointerEvent coordinates fractional for touch

third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp

 /*
  * Copyright (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2003, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 56 matching lines @@
                           canBubble,
                           cancelable,
                           abstractView,
                           detail,
                           modifiers,
                           platformTimeStamp,
                           sourceCapabilities),
       m_screenLocation(screenLocation),
       m_movementDelta(movementDelta),
       m_positionType(positionType) {
-  LayoutPoint adjustedPageLocation;
-  LayoutSize scrollOffset;
+  DoublePoint adjustedPageLocation;
+  DoubleSize scrollOffset;
 
   LocalFrame* frame = view() && view()->isLocalDOMWindow()
                           ? toLocalDOMWindow(view())->frame()
                           : nullptr;
   if (frame && hasPosition()) {
     if (FrameView* frameView = frame->view()) {
-      scrollOffset = LayoutSize(frameView->scrollOffsetInt());
       adjustedPageLocation = frameView->rootFrameToContents(rootFrameLocation);
+      scrollOffset = frameView->scrollOffsetInt();
       float scaleFactor = 1 / frame->pageZoomFactor();
       if (scaleFactor != 1.0f) {
         adjustedPageLocation.scale(scaleFactor, scaleFactor);
         scrollOffset.scale(scaleFactor, scaleFactor);
       }
     }
   }
 
   m_clientLocation = adjustedPageLocation - scrollOffset;
   m_pageLocation = adjustedPageLocation;
 
   // Set up initial values for coordinates.
   // Correct values are computed lazily, see computeRelativePosition.
   m_layerLocation = m_pageLocation;
   m_offsetLocation = m_pageLocation;
 
   computePageLocation();
   m_hasCachedRelativePosition = false;
 }
 
 MouseRelatedEvent::MouseRelatedEvent(const AtomicString& eventType,
                                      const MouseEventInit& initializer)
     : UIEventWithKeyState(eventType, initializer),
-      m_screenLocation(IntPoint(initializer.screenX(), initializer.screenY())),
+      m_screenLocation(
+          DoublePoint(initializer.screenX(), initializer.screenY())),
       m_movementDelta(
           IntPoint(initializer.movementX(), initializer.movementY())),
       m_positionType(PositionType::Position) {
-  initCoordinates(IntPoint(initializer.clientX(), initializer.clientY()));
+  initCoordinates(initializer.clientX(), initializer.clientY());
 }
 
-void MouseRelatedEvent::initCoordinates(const LayoutPoint& clientLocation) {
+void MouseRelatedEvent::initCoordinates(const double clientX,
+                                        const double clientY) {
   // Set up initial values for coordinates.
   // Correct values are computed lazily, see computeRelativePosition.
-  m_clientLocation = clientLocation;
-  m_pageLocation = clientLocation + contentsScrollOffset(view());
+  m_clientLocation = DoublePoint(clientX, clientY);
+  m_pageLocation = m_clientLocation + DoubleSize(contentsScrollOffset(view()));
 
   m_layerLocation = m_pageLocation;
   m_offsetLocation = m_pageLocation;
 
   computePageLocation();
   m_hasCachedRelativePosition = false;
 }
 
 static float pageZoomFactor(const UIEvent* event) {
   if (!event->view() || !event->view()->isLocalDOMWindow())
     return 1;
   LocalFrame* frame = toLocalDOMWindow(event->view())->frame();
   if (!frame)
     return 1;
   return frame->pageZoomFactor();
 }
 
 void MouseRelatedEvent::computePageLocation() {
   float scaleFactor = pageZoomFactor(this);
-  setAbsoluteLocation(
-      LayoutPoint(FloatPoint(pageX() * scaleFactor, pageY() * scaleFactor)));
+  m_absoluteLocation = m_pageLocation.scaledBy(scaleFactor);
 }
 
 void MouseRelatedEvent::receivedTarget() {
   m_hasCachedRelativePosition = false;
 }
 
 static const LayoutObject* findTargetLayoutObject(Node*& targetNode) {
   LayoutObject* layoutObject = targetNode->layoutObject();
   if (!layoutObject || !layoutObject->isSVG())
     return layoutObject;
@@ skipping 27 matching lines @@
 
     // Adding this here to address crbug.com/570666. Basically we'd like to
     // find the local coordinates relative to the padding box not the border
     // box.
     if (layoutObject->isBoxModelObject()) {
       const LayoutBoxModelObject* layoutBox =
           toLayoutBoxModelObject(layoutObject);
       localPos.move(-layoutBox->borderLeft(), -layoutBox->borderTop());
     }
 
-    m_offsetLocation = LayoutPoint(localPos);
+    m_offsetLocation = DoublePoint(localPos);
     float scaleFactor = 1 / pageZoomFactor(this);
     if (scaleFactor != 1.0f)
       m_offsetLocation.scale(scaleFactor, scaleFactor);
   }
 
   // Adjust layerLocation to be relative to the layer.
   // FIXME: event.layerX and event.layerY are poorly defined,
   // and probably don't always correspond to PaintLayer offsets.
   // https://bugs.webkit.org/show_bug.cgi?id=21868
   Node* n = targetNode;
   while (n && !n->layoutObject())
     n = n->parentNode();
 
   if (n) {
     // FIXME: This logic is a wrong implementation of convertToLayerCoords.
     for (PaintLayer* layer = n->layoutObject()->enclosingLayer(); layer;
-         layer = layer->parent())
-      m_layerLocation -= toLayoutSize(layer->location());
+         layer = layer->parent()) {
+      m_layerLocation -= DoubleSize(layer->location().x().toDouble(),
+                                    layer->location().y().toDouble());
+    }
   }
 
   m_hasCachedRelativePosition = true;
 }
 
 int MouseRelatedEvent::layerX() {
   if (!m_hasCachedRelativePosition)
     computeRelativePosition();
-  return m_layerLocation.x().toInt();
+
+  // TODO(mustaq): Remove the PointerEvent specific code when mouse has
+  // fractional coordinates. See crbug.com/655786.
+  return isPointerEvent() ? m_layerLocation.x()
+                          : static_cast<int>(m_layerLocation.x());
 }
 
 int MouseRelatedEvent::layerY() {
   if (!m_hasCachedRelativePosition)
     computeRelativePosition();
-  return m_layerLocation.y().toInt();
+
+  // TODO(mustaq): Remove the PointerEvent specific code when mouse has
+  // fractional coordinates. See crbug.com/655786.
+  return isPointerEvent() ? m_layerLocation.y()
+                          : static_cast<int>(m_layerLocation.y());
 }
 
 int MouseRelatedEvent::offsetX() {
   if (!hasPosition())
     return 0;
   if (!m_hasCachedRelativePosition)
     computeRelativePosition();
-  return roundToInt(m_offsetLocation.x());
+  return std::round(m_offsetLocation.x());
 }
 
 int MouseRelatedEvent::offsetY() {
   if (!hasPosition())
     return 0;
   if (!m_hasCachedRelativePosition)
     computeRelativePosition();
-  return roundToInt(m_offsetLocation.y());
-}
-
-int MouseRelatedEvent::pageX() const {
-  return m_pageLocation.x().toInt();
-}
-
-int MouseRelatedEvent::pageY() const {
-  return m_pageLocation.y().toInt();
-}
-
-int MouseRelatedEvent::x() const {
-  // FIXME: This is not correct.
-  // See Microsoft documentation and
-  // <http://www.quirksmode.org/dom/w3c_events.html>.
-  return m_clientLocation.x().toInt();
-}
-
-int MouseRelatedEvent::y() const {
-  // FIXME: This is not correct.
-  // See Microsoft documentation and
-  // <http://www.quirksmode.org/dom/w3c_events.html>.
-  return m_clientLocation.y().toInt();
+  return std::round(m_offsetLocation.y());
 }
 
 DEFINE_TRACE(MouseRelatedEvent) {
   UIEventWithKeyState::trace(visitor);
 }
 
 }  // namespace blink