Introduce test output snippet byte limit

Introduce test output snippet byte limit

Also see https://goto.google.com/epoll for context.

BUG=634418
Committed: https://crrev.com/9aceda5e0c82ea57446209e31becbea91fdeb0b0
Cr-Commit-Position: refs/heads/master@{#425038}

[Paweł Hajdan Jr., 2016-10-12 18:11:58]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 18:12:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2016-10-12 18:33:51]

phajdan.jr@chromium.org changed reviewers:
+ dpranke@chromium.org, jam@chromium.org

[commit-bot: I haz the power, 2016-10-12 19:24:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 19:24:31]

Dry run: This issue passed the CQ dry run.

[jam, 2016-10-12 21:23:17]

lgtm

[Dirk Pranke, 2016-10-12 23:33:27]

lgtm w/ nits and questions.

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_lau...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_lau...
base/test/launcher/test_launcher.cc:583: result.output_snippet =
"<truncated>\n";
Maybe this should include at least some of the snippet? 

Also, it seems like even 10MB is much too generous, I would want to understand
why any test would need more than a KB or two of output. But, it's fine to start
high and ratchet down.

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_res...
File base/test/launcher/test_result.cc (right):

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_res...
base/test/launcher/test_result.cc:36: return "EXCESSIVE_OUTPUT";
Are these codes propagated into the json test results that are uploaded to the
flakiness dashboard, or are they mapped into 'FAILURE' somewhere?

[Paweł Hajdan Jr., 2016-10-13 07:17:18]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:17:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 07:39:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 07:40:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Paweł Hajdan Jr., 2016-10-13 08:57:13]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 08:57:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 09:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 09:19:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Paweł Hajdan Jr., 2016-10-13 11:17:26]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 11:17:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2016-10-13 12:02:31]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 12:02:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 12:38:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 12:38:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Paweł Hajdan Jr., 2016-10-13 14:18:44]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 14:19:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2016-10-13 14:55:59]

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_lau...
File base/test/launcher/test_launcher.cc (right):

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_lau...
base/test/launcher/test_launcher.cc:583: result.output_snippet =
"<truncated>\n";
On 2016/10/12 at 23:33:27, Dirk Pranke wrote:
> Maybe this should include at least some of the snippet? 

Done.

> Also, it seems like even 10MB is much too generous, I would want to understand
why any test would need more than a KB or two of output. But, it's fine to start
high and ratchet down.

It turns out (tested on trybots) we need 2.5 MB limit. I'll probably work on
reducing that. Only a limited number of tests are affected.

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_res...
File base/test/launcher/test_result.cc (right):

https://codereview.chromium.org/2406243004/diff/1/base/test/launcher/test_res...
base/test/launcher/test_result.cc:36: return "EXCESSIVE_OUTPUT";
On 2016/10/12 at 23:33:27, Dirk Pranke wrote:
> Are these codes propagated into the json test results that are uploaded to the
flakiness dashboard, or are they mapped into 'FAILURE' somewhere?

Current code will behave correctly, and with
https://codereview.chromium.org/2408423005 it'll recognize this new specific
code.

[Paweł Hajdan Jr., 2016-10-13 14:56:17]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-10-13 14:56:21]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-10-13 14:56:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2406243004/#ps100001
(title: "2.5 MB")

[commit-bot: I haz the power, 2016-10-13 14:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:33:13]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-13 15:35:40]

Description was changed from

==========
Introduce test output snippet byte limit

Also see https://goto.google.com/epoll for context.

BUG=634418
==========

to

==========
Introduce test output snippet byte limit

Also see https://goto.google.com/epoll for context.

BUG=634418

Committed: https://crrev.com/9aceda5e0c82ea57446209e31becbea91fdeb0b0
Cr-Commit-Position: refs/heads/master@{#425038}
==========

[commit-bot: I haz the power, 2016-10-13 15:35:41]

Patchset 6 (id:??) landed as
https://crrev.com/9aceda5e0c82ea57446209e31becbea91fdeb0b0
Cr-Commit-Position: refs/heads/master@{#425038}