Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2406243002: [turbofan] Look at nodes instead of types for string data (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Look at nodes instead of types for string data We'll stop storing string data in Type objects. At the moment, we have optimizations that read that string data in typed lowering. Instead, look at nodes for this data. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/070a44f9240c28086dcb7ca8833434825bf15b46 Cr-Commit-Position: refs/heads/master@{#40173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M src/compiler/js-typed-lowering.cc View 3 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mvstanton
Hi Benedikt, Here is one of the changes we discussed, --Mike
4 years, 2 months ago (2016-10-11 12:40:43 UTC) #1
mvstanton
Hi Jaro, could you have a look instead?
4 years, 2 months ago (2016-10-11 13:02:21 UTC) #5
Jarin
lgtm
4 years, 2 months ago (2016-10-11 13:08:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406243002/1
4 years, 2 months ago (2016-10-11 13:12:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 13:14:37 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 13:15:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/070a44f9240c28086dcb7ca8833434825bf15b46
Cr-Commit-Position: refs/heads/master@{#40173}

Powered by Google App Engine
This is Rietveld 408576698