Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2406233004: Revert of cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS (patchset #16 id:300001 of https://codereview.chromium.org/2384053002/ ) Reason for revert: Broke the build https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/26848 Original issue's description: > cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS > > For this bug convert ET_MOUSE_EXITED to MouseLeave in ChromeOS and make the > scrollbar thin and light when we receive MouseLeave. > > For other platform, we will fix this bug after crbug.com/450631 > BUG=332227 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/3ba6cb3d9518e9a54f006fd6288438c211ba8998 > Cr-Commit-Position: refs/heads/master@{#424531} TBR=aelias@chromium.org,bokan@chromium.org,dtapuska@chromium.org,chaopeng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=332227 Committed: https://crrev.com/307e66d18de17bfc7168adefd2306aa4be96f17e Cr-Commit-Position: refs/heads/master@{#424545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -60 lines) Patch
M cc/input/input_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/input/scrollbar_animation_controller_thinning.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/input/scrollbar_animation_controller_thinning_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/blink/web_input_event.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
Created Revert of cancel overlay-scrollbar hover state when moving pointer out of window for ChromeOS
4 years, 2 months ago (2016-10-11 21:00:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406233004/1
4 years, 2 months ago (2016-10-11 21:00:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 21:02:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8bded616cb189101cd5d70e2a94a1ae39e10f3da Cr-Commit-Position: refs/heads/master@{#424544}
4 years, 2 months ago (2016-10-11 21:03:43 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 21:06:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/307e66d18de17bfc7168adefd2306aa4be96f17e
Cr-Commit-Position: refs/heads/master@{#424545}

Powered by Google App Engine
This is Rietveld 408576698